[data.search.session] Server telemetry on search sessions #91256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasolson
added
review
Feature:Search
pgayvallet
approved these changes
Feb 12, 2021
Bamieh
approved these changes
Feb 15, 2021
| }, | ||
| }); | ||
| usageCollection.registerCollector(collector); | ||
| } catch (err) { |
There was a problem hiding this comment.
NIT: I dont see any reason to have this try/catch in place. usageCollection is not optional in this function parameters and we never throw on collection registration.
lizozom
approved these changes
Feb 15, 2021
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
lizozom
pushed a commit
to lizozom/kibana
that referenced
this pull request
Feb 15, 2021
) * [data.search.session] Server telemetry on search sessions * Update telemetry mappings * Added tests and logger Co-authored-by: Liza K <[email protected]>
lizozom
added a commit
that referenced
this pull request
Feb 15, 2021
…91410) * [data.search.session] Server telemetry on search sessions * Update telemetry mappings * Added tests and logger Co-authored-by: Liza K <[email protected]> Co-authored-by: Lukas Olson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #62964.
Adds server-side telemetry for search sessions. Right now all it reports is the number of persisted/transient sessions, as well as the total count, but we can extend this to report more stats.