Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused common folder #91199

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

mshustov
Copy link
Contributor

Summary

I didn't manage to find any references

@mshustov mshustov added chore v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Feb 11, 2021
@mshustov mshustov requested a review from a team February 11, 2021 19:29
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov enabled auto-merge (squash) February 11, 2021 21:43
@mshustov mshustov added the auto-backport Deprecated - use backport:version if exact versions are needed label Feb 11, 2021
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow thanks for pointing this out.

This is a copy of a generated file that should definitely not have ended up where it is. We merged it a long time ago, the original version of this file was deleted from our own plugin over a year ago. Guessing this couldn't happen today because we have CODEOWNERS set up now. cc @andrewvc

@mshustov mshustov merged commit 734f4c0 into elastic:master Feb 11, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 11, 2021
@kibanamachine
Copy link
Contributor

Backport result

{"level":"info","message":"POST https://api.github.com/graphql (status: 200)"}
{"level":"info","message":"POST https://api.github.com/graphql (status: 200)"}
{"meta":{"labels":["auto-backport","chore","release_note:skip","v7.12.0","v8.0.0"],"branchLabelMapping":{"^v8.0.0$":"master","^v7.12.0$":"7.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"},"existingTargetPullRequests":[]},"level":"info","message":"Inputs when calculating target branches:"}
{"meta":["7.x"],"level":"info","message":"Target branches inferred from labels:"}
{"meta":{"killed":false,"code":2,"signal":null,"cmd":"git remote rm kibanamachine","stdout":"","stderr":"error: No such remote: 'kibanamachine'\n"},"level":"info","message":"exec error 'git remote rm kibanamachine':"}
{"meta":{"killed":false,"code":2,"signal":null,"cmd":"git remote rm elastic","stdout":"","stderr":"error: No such remote: 'elastic'\n"},"level":"info","message":"exec error 'git remote rm elastic':"}
{"level":"info","message":"Backporting [{\"sourceBranch\":\"master\",\"targetBranchesFromLabels\":[\"7.x\"],\"sha\":\"734f4c02f0e291fc16b6edd139e98d166ee0d56c\",\"formattedMessage\":\"remove unused folder (#91199)\",\"originalMessage\":\"remove unused folder (#91199)\",\"pullNumber\":91199,\"existingTargetPullRequests\":[]}] to 7.x"}

Backporting to 7.x:
{"level":"info","message":"Backporting via filesystem"}
{"level":"info","message":"Creating PR with title: \"[7.x] remove unused folder (#91199)\". kibanamachine:backport/7.x/pr-91199 -> 7.x"}
{"level":"info","message":"POST /repos/elastic/kibana/pulls - 201 in 1065ms"}
{"level":"info","message":"Adding assignees to #91227: restrry"}
{"level":"info","message":"POST /repos/elastic/kibana/issues/91227/assignees - 201 in 500ms"}
{"level":"info","message":"Adding labels: backport"}
{"level":"info","message":"POST /repos/elastic/kibana/issues/91227/labels - 200 in 385ms"}
View pull request: https://github.com/elastic/kibana/pull/91227

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 15, 2021
@mshustov mshustov deleted the remove-unused-common-folder branch February 16, 2021 19:33
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

mshustov added a commit that referenced this pull request Feb 17, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants