[Logs UI] Check for privileges with user management links #91134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerry350
added
release_note:fix
v8.0.0
Feature:Logs UI
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
|
@elasticmachine merge upstream |
weltenwort
approved these changes
Feb 15, 2021
x-pack/plugins/infra/public/components/logging/log_analysis_setup/user_management_link.tsx
Outdated
Show resolved
Hide resolved
…tup/user_management_link.tsx Co-authored-by: Felix Stürmer <[email protected]>
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Kerry350
added a commit
that referenced
this pull request
Feb 16, 2021
…91490) * Wrap users management link with privileges check Co-authored-by: Kibana Machine <[email protected]>
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #79264.
I'd considered hoisting these checks one level higher to the prompts (setup and results) and only conditionally providing the
actionsto the EUI prompt, or even wrapping the results / setup privileges prompts with a new component that could pass acanAccessUserManagementprop, but honestly both just seemed needlessly complex.Testing
Across both the categories and anomalies pages, and also across both the setup scenario and the viewing results scenario, if the user is lacking in ML privileges the Manage Users button should only appear if the user has the sufficient management privileges (
management > security > users).