[ML] Fix DFA feature importance popover empty #91061
Conversation
qn895
added
:ml
Feature:Data Frame Analytics
|
Pinging @elastic/ml-ui (:ml) |
qn895
changed the title
| importance: importance[index], | ||
| }) | ||
| : fi.classes, | ||
| importance: Array.isArray(fi.importance) ? fi.importance[0] : fi.importance, |
There was a problem hiding this comment.
From the type, it looks like 'importance' is a number. If it can also be an array of numbers it might be worth updating the type.
|
Sure it isn't related to the changes here, but the tooltip is often rendering below the popover for me:
|
| // Make sure the charts tooltip in popover | ||
| // have higher zIndex than Eui popover cells | ||
| [id^='echTooltipPortal'] { | ||
| z-index: 10000; |
There was a problem hiding this comment.
This works for me only when adding !important as otherwise it gets overridden by the inline style.
There was a problem hiding this comment.
Thanks Pete, this is now updated here 3f76bf8
| // Make sure the charts tooltip in popover | ||
| // have higher zIndex than Eui popover cells | ||
| [id^='echTooltipPortal'] { | ||
| z-index: 10000 !important; |
There was a problem hiding this comment.
Assuming this achieves the same result, consider changing to an EUI z-index variable.
| z-index: 10000 !important; | |
| z-index: $euiZLevel9 !important; |
qn895
added
the
auto-backport
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Co-authored-by: Quynh Nguyen <[email protected]>
Summary
This PR fixes #90603 which was introduced due to recent
fieldsAPI changes. It also unskip related functional tests that were previously skipped here #90526Classification
Regression
Review Hints:
expandable_section.scssto fix the z-index of the Elastic charts tooltip (100) much smaller than the Eui popover z-index (8001)Checklist