-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TS project refs: Converts rollup, remoteClusters, crossClusterReplication, indexLifecycleManagement to a TS project refs #90713
Merged
TinaHeiligers
merged 6 commits into
elastic:master
from
TinaHeiligers:ts-project-refs/rollup_remoteclusters_ccr_ILM
Feb 9, 2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinaHeiligers
added
chore
v8.0.0
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
release_note:skip
Skip the PR/issue when compiling release notes
v7.12.0
labels
Feb 9, 2021
TinaHeiligers
changed the title
Converts rollup to a TS project ref
TS project refs: Converts rollup, remoteClusters, crossClusterReplication, indexLifecycleManagement to a TS project refs
Feb 9, 2021
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
yuliacech
approved these changes
Feb 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @TinaHeiligers , thanks a lot for migrating those plugins!
changes LGTM! 👍
TinaHeiligers
added
the
auto-backport
Deprecated - use backport:version if exact versions are needed
label
Feb 9, 2021
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Backport result
|
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 9, 2021
…tion, indexLifecycleManagement to a TS project refs (elastic#90713) Co-authored-by: Kibana Machine <[email protected]>
TinaHeiligers
added a commit
that referenced
this pull request
Feb 9, 2021
…eplication, indexLifecycleManagement to a TS project refs (#90713) (#90837) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Christiane (Tina) Heiligers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Deprecated - use backport:version if exact versions are needed
chore
release_note:skip
Skip the PR/issue when compiling release notes
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
v7.12.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #89321
Converts the following plugins to TS project references:
Partial stats from running
node --max-old-space-size=4096 ./node_modules/.bin/tsc -p x-pack/tsconfig.json --extendedDiagnostics --noEmit
:Before:
Files: 11252
Lines: 1246802
After:
Files: 10564
Lines: 1213000