Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search Sessions] added an info flyout to session management #90559

Merged
merged 12 commits into from
Feb 10, 2021

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Feb 7, 2021

Summary

Added a flyout showing the original state used to create each search session in management

image

image

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@lizozom lizozom added v8.0.0 Team:AppServices release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Feb 7, 2021
@lizozom lizozom self-assigned this Feb 7, 2021
@lizozom lizozom requested a review from a team as a code owner February 7, 2021 15:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@lizozom lizozom requested a review from Dosant February 8, 2021 18:29
@lizozom lizozom requested a review from a team as a code owner February 8, 2021 18:29
Copy link
Contributor

@mdefazio mdefazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts on icons and verbiage, but @gchaps or someone might have better ideas.

@lizozom
Copy link
Contributor Author

lizozom commented Feb 8, 2021

@elasticmachine merge upstream

Copy link
Member

@lukasolson lukasolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I did notice that we don't show "Delete" as an option for search sessions in an Error state, but I doubt it's related to the changes in this PR.

@lizozom lizozom requested a review from mdefazio February 9, 2021 17:08
@lizozom lizozom requested a review from gchaps February 10, 2021 11:17
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dataEnhanced 94 104 +10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataEnhanced 147.6KB 160.1KB +12.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

lizozom added a commit to lizozom/kibana that referenced this pull request Feb 10, 2021
…#90559)

* added an info flyout to session management

* better filter serialization

* Fix jest tests

* jest

* display the originalState as a json object

* code review

* Text improvements

Co-authored-by: Kibana Machine <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 10, 2021
* master: (99 commits)
  [Fleet] Use Fleet Server indices in the search bar (elastic#90835)
  [Search Sessions] added an info flyout to session management (elastic#90559)
  [ILM] Revisit searchable snapshot field after new redesign (elastic#90793)
  [Alerting] License Errors on Alert List View (elastic#89920)
  RFC Improve saved object migrations algorithm (elastic#84333)
  [Lens] (Accessibility) Fix focus on drag and drop actions (elastic#90561)
  Use new shortcut links to Fleet discuss forums. (elastic#90786)
  Do not generate an ephemeral encryption key in production. (elastic#81511)
  [Fleet] Use staging registry for snapshot builds (elastic#90327)
  Actually deleting x-pack/tsconfig.refs.json (elastic#90898)
  Add deprecation warning to all Beats CM pages. (elastic#90741)
  skip flaky suite (elastic#90136)
  Revert "Revert "[Metrics UI] Add Metrics Anomaly Alert Type (elastic#89244)"" (elastic#90889)
  remove ref to removed tsconfig file
  [core.logging] Uses host timezone as default (elastic#90368)
  [Maps] remove maps_file_upload plugin and fold public folder into file_upload plugin (elastic#90292)
  Revert "[Metrics UI] Add Metrics Anomaly Alert Type (elastic#89244)"
  [dev-utils/ci-stats] support disabling ship errors (elastic#90851)
  Prefix with / (elastic#90836)
  [Metrics UI] Add Metrics Anomaly Alert Type (elastic#89244)
  ...
lizozom added a commit that referenced this pull request Feb 10, 2021
…#90943)

* added an info flyout to session management

* better filter serialization

* Fix jest tests

* jest

* display the originalState as a json object

* code review

* Text improvements

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants