Update eslint-plugin-import to latest 2.22.1 #90483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-to grab fixes, case-sensitivity, etc.
cee-chen
added
release_note:skip
JasonStoltz
approved these changes
Feb 5, 2021
|
We shouldn't, I received confirmation from Spalger and Mikhail that this was totally OK to do if all tests passed! |
cee-chen
pushed a commit
to cee-chen/kibana
that referenced
this pull request
Feb 5, 2021
-to grab fixes, case-sensitivity, etc.
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
cee-chen
pushed a commit
that referenced
this pull request
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates
eslint-plugin-importfrom 2.19.1 to 2.22.1. Changelog linkThe Enterprise Search team would like this change as we're attempting to add more linting rules around our import order and running into some shenanigans with alphabetizing. Specifically, when I added the
alphabetizerule afternewlines-betweenI started getting a bunch of weird/incorrect errors about the plugin wanting newlines between every single import line. Upgrading seemed to fix the issue 🤷Checklist