Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Expressions] [Lens] Add id and copyMetaFrom arg to mapColumn fn + add configurable onError argument to math fn #90481

Merged
merged 23 commits into from
Feb 25, 2021
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
2fc8e67
:truck: Move mapColumn to expressions plugin
dej611 Feb 5, 2021
2f1e324
Merge branch 'master' into expression/mapColumn-ext
kibanamachine Feb 9, 2021
744f39a
Merge branch 'master' into expression/mapColumn-ext
kibanamachine Feb 11, 2021
b00b9dc
Merge branch 'master' into expression/mapColumn-ext
kibanamachine Feb 15, 2021
96c3aae
:globe_with_meridians: Fix i18n for mapColumns
dej611 Feb 15, 2021
241aa03
:truck: Move over the math function to shared expressions plugin
dej611 Feb 15, 2021
b89934f
:sparkles: Add new onError argument
dej611 Feb 15, 2021
4c8fd8c
:globe_with_meridians: Fix i18n for math
dej611 Feb 15, 2021
75fecc8
:memo: Update expressions doc with new args
dej611 Feb 16, 2021
abbdbbc
Merge branch 'master' into expression/mapColumn-ext
kibanamachine Feb 18, 2021
7eb7ebd
:sparkles: Add the divide by zero handling
dej611 Feb 18, 2021
804507a
:sparkles: Add options for autocomplete
dej611 Feb 18, 2021
88a7d36
Merge branch 'master' into expression/mapColumn-ext
kibanamachine Feb 19, 2021
0ba2ce9
Merge branch 'master' into expression/mapColumn-ext
kibanamachine Feb 22, 2021
0ac1f27
:bug: Fix bug wth type picker
dej611 Feb 22, 2021
eb841bc
Merge branch 'expression/mapColumn-ext' of github.com:dej611/kibana i…
dej611 Feb 22, 2021
2579d0e
Merge branch 'master' into expression/mapColumn-ext
kibanamachine Feb 23, 2021
a5c8bdf
:ok_hand: Integrated feedback
dej611 Feb 23, 2021
6bfa823
:bug: Fix unused value
dej611 Feb 23, 2021
a6cb2d0
:white_check_mark: Add more tests
dej611 Feb 24, 2021
7cdf96f
:bug: Fix type issue
dej611 Feb 24, 2021
0f601c0
:white_check_mark: Fix unit test
dej611 Feb 24, 2021
b8aff19
Merge branch 'master' into expression/mapColumn-ext
kibanamachine Feb 24, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
✅ Fix unit test
  • Loading branch information
dej611 committed Feb 24, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 0f601c013da33772430f9bb41eba1fbd2590ccd5
Original file line number Diff line number Diff line change
@@ -105,7 +105,7 @@ describe('mapColumn', () => {
expect(result.columns[nameColumnIndex]).toEqual({
id: 'name',
name: 'name',
meta: { type: 'date', params: { type: 'date', digits: 2 } },
meta: { type: 'date', params: { id: 'number', params: { digits: 2 } } },
});
});
});