[Logs UI] Use async search in the log stream page #90303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 4, 2021 11:34
afgomez
added
v8.0.0
Feature:Logs UI
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
Kerry350
requested changes
Feb 8, 2021
There was a problem hiding this comment.
Code looks good, nice to see the higher order component gone 👍
I did find a couple of bugs in the functionality though:
- Using the filter bar seems to throw an error.
- When I load some log entries, then go to another page, and then come back to the Stream page, it says "There are no log messages to display." I have to click "Check for new data" to see entries again. On that navigation back to the Stream there isn't a request in the network panel.
| import { useLogStreamContext } from '../../../containers/logs/log_stream'; | ||
| import { datemathToEpochMillis, isValidDatemath } from '../../../utils/datemath'; | ||
|
|
||
| // FIXME Duplicated from <LogStream />. See where to put this |
There was a problem hiding this comment.
Should this be fixed before merge?
There was a problem hiding this comment.
I think I'm OK with the duplication. We might want the pagination to work differently here than in the <LogStream /> component.
The subscription timing is slightly unpredictable due to React's effect execution order. This way initial requests won't get lost. The response$ is multicast already due to `share()`, so I don't expect any negative consequences. (famous last words)
Kerry350
approved these changes
Feb 11, 2021
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
afgomez
pushed a commit
that referenced
this pull request
Feb 12, 2021
) Co-authored-by: Felix Stürmer <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Felix Stürmer <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #86439
This PR modifies the log stream page to make use of async searches. To do so it replaces the existing
useLogEntriescontainer withuseLogStream, which already uses async search.Summary of changes
<WithStreamItems>HOC.fetchPreviousandfetchNextcallbacks inuseLogStream, to allow fetching before or after the timestamp range. This is necessary for the "extend range" buttons to work correctly.useLogEntrieshook./log_entries/entriesendpoint and its related types.