Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kbn/es] avoid splitting string esArgs into separate args #90253

Merged
merged 2 commits into from
Feb 4, 2021
Merged

[kbn/es] avoid splitting string esArgs into separate args #90253

merged 2 commits into from
Feb 4, 2021

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Feb 3, 2021

With #88986 I accidentally broke the esArgs handling because the type was expected to be an array, but a string is passed when only a single argument is passed. This changes the joining to use [].concat() so that strings and arrays will be adapted to as intended.

@spalger spalger added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Feb 3, 2021
@spalger spalger requested a review from a team as a code owner February 3, 2021 23:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

myasonik
myasonik approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit df4eb0f into elastic:master Feb 4, 2021
@spalger spalger deleted the fix/es-args-parsing branch February 4, 2021 04:58
@spalger spalger added the v7.12.0 label Feb 4, 2021
@spalger spalger mentioned this pull request Feb 4, 2021
Merged
spalger pushed a commit that referenced this pull request Feb 4, 2021
[kbn/es] avoid splitting string esArgs into separate args (#90253) (#…
a3b5557 
…90257)

Co-authored-by: spalger <[email protected]>
# Conflicts:
#	packages/kbn-es/src/cluster.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

@myasonik myasonik myasonik approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spalger @elasticmachine @kibanamachine @tylersmalley @myasonik