[QA] Create Saved Objects Kibana Svc #90251

wayneseymour · 2021-02-03T23:25:06Z

Add svc,
integrate into one test,
and add exported saved objects.

Partially closes #89368

wayneseymour · 2021-02-04T17:13:03Z

@LeeDr Looks like the test that's using the new svc passed:

[2021-02-04T00:14:29.451Z]                └- ✓ pass  (4.4s) "discover app discover test query should show correct time range string by timepicker"
[2021-02-04T00:14:29.452Z]              └-> save query should show toast message and display query name
[2021-02-04T00:14:29.452Z]                └-> "before each" hook: global before each for "save query should show toast message and display query name"
[2021-02-04T00:14:29.883Z]      │ info [o.e.t.NettyAllocator] [kibana-ci-immutable-centos-tests-xxl-1612395597759933847] creating NettyAllocator with the following configs: [name=unpooled, suggested_max_allocation_size=1mb, factors={es.unsafe.use_unpooled_allocator=null, g1gc_enabled=true, g1gc_region_size=4mb, heap_size=1gb}]
[2021-02-04T00:14:29.883Z]      │ info [o.e.d.DiscoveryModule] [kibana-ci-immutable-centos-tests-xxl-1612395597759933847] using discovery type [single-node] and seed hosts providers

https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/103657/consoleText

test/functional/apps/discover/_discover.ts

LeeDr · 2021-02-08T19:01:13Z

Do we need something like this to tell where the savedObject files are? The default location is set somewhere and this x-pack test config overrides that.
https://github.com/elastic/kibana/blob/master/x-pack/test/functional/config.js#L203

wayneseymour · 2021-02-09T00:09:52Z

Do we need something like this to tell where the savedObject files are? The default location is set somewhere and this x-pack test config overrides that.
https://github.com/elastic/kibana/blob/master/x-pack/test/functional/config.js#L203

Gonna add the schema update next boss!

test/functional/services/saved_objects/fetch_saved_objects.ts

Add svc, integrate into one test, add exported saved objects, add empty kibana call, and update ftr schema...add data directory for the new svc.

Make public api take one argument.

Make typescript happier.

test/functional/services/saved_objects/utils.ts

wayneseymour · 2021-02-16T15:40:36Z

@elasticmachine merge upstream

wayneseymour · 2021-02-18T21:38:38Z

packages/kbn-test/src/kbn_archiver_cli.ts

+  const types = typeof flags.type === 'string' ? [flags.type] : flags.type;
+  return types.reduce(
+    (acc: string[], type) => [...acc, ...type.split(',').map((t) => t.trim())],
+    []


packages/kbn-test/src/kbn_client/kbn_client_import_export.ts

…objs-svc

test/functional/apps/discover/_discover.ts

yarn.lock

…objs-svc

wayneseymour · 2021-02-22T20:38:36Z

@spalger Hey chief, I've been "talked to" about dumping auth info to the console.
Do we need to redact here:

[00:07:20]               └- ✖ fail: discover app discover test "before all" hook in "discover test"

...

[00:07:20]               │ req: {
[00:07:20]               │   url: 'http://elastic:changeme@localhost:61161/api/saved_objects/_import',

...

Perhaps it's no biggie in this case?

spalger · 2021-02-22T21:44:22Z

Perhaps it's no biggie in this case?

Yeah, in this case the authentication isn't sensitive information and having all potentially applicable info is probably more helpful than spending time obfuscating details like the headers of the request or the username/password used.

spalger · 2021-02-22T23:58:34Z

@elasticmachine merge upstream

spalger · 2021-02-23T17:36:17Z

@elasticmachine merge upstream

spalger · 2021-02-23T20:47:32Z

@elasticmachine merge upstream

spalger · 2021-02-23T21:05:23Z

@wayneseymour, hope you don't mind but I'm going to reopen this as a new PR from my fork and take over getting it merged. Thanks for getting this started and for your assistance reviewing!

wayneseymour · 2021-02-23T21:11:45Z

@spalger code on coder!!! :)

kibanamachine · 2021-02-23T23:18:24Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 89a607e
Storybooks Preview
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures
Documentation Changes

Failed CI Steps

Test Failures

Kibana Pipeline / general / Deletes and recovers more than one rule.Deleting prebuilt rules Deletes and recovers more than one rule

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

AssertionError: Timed out retrying after 60000ms: expected '<button.euiButton.euiButton--primary>' to have text 'Install 2 Elastic prebuilt rules ', but the text was 'Install 1 Elastic prebuilt rule '
    at Context.eval (http://localhost:6111/__cypress/tests?p=cypress/integration/detection_rules/prebuilt_rules.spec.ts:20253:68)

Kibana Pipeline / general / Deletes and recovers more than one rule.Deleting prebuilt rules Deletes and recovers more than one rule

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://dryrun

AssertionError: Timed out retrying after 60000ms: expected '<button.euiButton.euiButton--primary>' to have text 'Install 2 Elastic prebuilt rules ', but the text was 'Install 1 Elastic prebuilt rule '
    at Context.eval (http://localhost:6111/__cypress/tests?p=cypress/integration/detection_rules/prebuilt_rules.spec.ts:20253:68)

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @wayneseymour

wayneseymour force-pushed the create-saved-objs-svc branch from 616d957 to ed7d55d Compare February 3, 2021 23:39

wayneseymour requested a review from LeeDr February 4, 2021 17:14

wayneseymour force-pushed the create-saved-objs-svc branch 2 times, most recently from b0ed22a to 6af33b5 Compare February 4, 2021 23:01

wayneseymour self-assigned this Feb 4, 2021

wayneseymour added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels Feb 4, 2021

LeeDr reviewed Feb 8, 2021

View reviewed changes

test/functional/apps/discover/_discover.ts Outdated Show resolved Hide resolved

wayneseymour force-pushed the create-saved-objs-svc branch from 6af33b5 to 909bf82 Compare February 9, 2021 00:07

wayneseymour force-pushed the create-saved-objs-svc branch from 909bf82 to ccec4a2 Compare February 9, 2021 19:04

wayneseymour marked this pull request as ready for review February 10, 2021 20:32

wayneseymour requested a review from a team as a code owner February 10, 2021 20:32

wayneseymour requested review from dmlemeshko and LeeDr February 10, 2021 20:32

LeeDr reviewed Feb 11, 2021

View reviewed changes

test/functional/services/saved_objects/fetch_saved_objects.ts Outdated Show resolved Hide resolved

wayneseymour added 2 commits February 11, 2021 13:22

[QA] Create Saved Objects FTR Svc

5a8150b

Add svc, integrate into one test, add exported saved objects, add empty kibana call, and update ftr schema...add data directory for the new svc.

[QA] Create Saved Objects FTR Svc

b4e6f4a

Make public api take one argument.

wayneseymour force-pushed the create-saved-objs-svc branch from ccec4a2 to b4e6f4a Compare February 11, 2021 20:41

wayneseymour requested a review from LeeDr February 11, 2021 20:42

[QA] Create Saved Objects FTR Svc

94a0709

Make typescript happier.

wayneseymour force-pushed the create-saved-objs-svc branch from ba3e6d6 to 94a0709 Compare February 11, 2021 21:39

LeeDr reviewed Feb 11, 2021

View reviewed changes

test/functional/services/saved_objects/utils.ts Outdated Show resolved Hide resolved

wayneseymour requested a review from LeeDr February 12, 2021 18:25

kibanamachine and others added 3 commits February 16, 2021 10:40

Merge branch 'master' into create-saved-objs-svc

317ab11

Merge branch 'master' into create-saved-objs-svc

2acd53e

refactor to import/export APIs on kbnClient

800c310

spalger added 6 commits February 17, 2021 13:25

rename methods to load/save

7965aa5

avoid importing types from src

6892174

add unload method

9b2f437

fix kbnArchiver.directory config getter

a739610

add clean() method for deleting objects by type

31fbc10

move clean and bulkDelete to savedObjects client

9dd92c8

wayneseymour commented Feb 18, 2021

View reviewed changes

wayneseymour commented Feb 19, 2021

View reviewed changes

packages/kbn-test/src/kbn_client/kbn_client_import_export.ts Show resolved Hide resolved

spalger added 2 commits February 22, 2021 10:18

Merge branch 'master' of github.com:elastic/kibana into create-saved-…

4f845e9

…objs-svc

pass KbnClientSavedObjects to KbnClientImportExport

346d6fa

wayneseymour commented Feb 22, 2021

View reviewed changes

test/functional/apps/discover/_discover.ts Show resolved Hide resolved

wayneseymour commented Feb 22, 2021

View reviewed changes

yarn.lock Outdated Show resolved Hide resolved

spalger added 3 commits February 22, 2021 12:56

Merge branch 'master' of github.com:elastic/kibana into create-saved-…

a729564

…objs-svc

strip sort field from exports

99eba13

rebuild discover export from esArchive

cd6a509

Merge branch 'master' into create-saved-objs-svc

24cc839

Merge branch 'master' into create-saved-objs-svc

8860be5

wayneseymour changed the title ~~[QA] Create Saved Objects FTR Svc~~ [QA] Create Saved Objects Kibana Svc Feb 23, 2021

Merge branch 'master' into create-saved-objs-svc

89a607e

spalger closed this Feb 23, 2021

spalger mentioned this pull request Feb 23, 2021

[kbn/test] add import/export support to KbnClient #92526

Merged

spalger deleted the create-saved-objs-svc branch February 23, 2021 21:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[QA] Create Saved Objects Kibana Svc #90251

[QA] Create Saved Objects Kibana Svc #90251

wayneseymour commented Feb 3, 2021

wayneseymour commented Feb 4, 2021

LeeDr commented Feb 8, 2021

wayneseymour commented Feb 9, 2021

wayneseymour commented Feb 16, 2021

wayneseymour Feb 18, 2021

wayneseymour commented Feb 22, 2021

spalger commented Feb 22, 2021

spalger commented Feb 22, 2021

spalger commented Feb 23, 2021

spalger commented Feb 23, 2021

spalger commented Feb 23, 2021

wayneseymour commented Feb 23, 2021

kibanamachine commented Feb 23, 2021 •

edited

Loading

Stack Trace

Stack Trace

[QA] Create Saved Objects Kibana Svc #90251

[QA] Create Saved Objects Kibana Svc #90251

Conversation

wayneseymour commented Feb 3, 2021

wayneseymour commented Feb 4, 2021

LeeDr commented Feb 8, 2021

wayneseymour commented Feb 9, 2021

wayneseymour commented Feb 16, 2021

wayneseymour Feb 18, 2021

Choose a reason for hiding this comment

wayneseymour commented Feb 22, 2021

spalger commented Feb 22, 2021

spalger commented Feb 22, 2021

spalger commented Feb 23, 2021

spalger commented Feb 23, 2021

spalger commented Feb 23, 2021

wayneseymour commented Feb 23, 2021

kibanamachine commented Feb 23, 2021 • edited Loading

💔 Build Failed

Failed CI Steps

Test Failures

Stack Trace

Stack Trace

Metrics [docs]

History

kibanamachine commented Feb 23, 2021 •

edited

Loading