[APM] Adding comparison to throughput chart

[cauemarcondes]

closes #90570

time.comparison.mov

[elasticmachine]

Pinging @elastic/apm-ui (Team:apm)

[cauemarcondes]

@elasticmachine merge upstream

[sorenlouv]

Why was this changed? It's not a biggie but does make the url a bit harder to read.

[cauemarcondes]

Nothing changes in the URL @sqren, I created a new runtime to convert from string (ISO) to number (timestamp). That's why this is now a number.

[dgieselaar]

Thanks for adding this! IMHO this is a bug. At least, I'm not sure why this function would not return data for the previous period if there is data. Instead of merging buckets, have you considered offsetting the data for the previous period by the time difference between end and comparisonEnd (or start and comparisonStart, not sure what the implications are)?

[cauemarcondes]

@dgieselaar I changed the merge function to calculate the x-axis from the previous timeseries based on the time difference (currentPeriodStart and previousPeriodStart)

https://github.com/elastic/kibana/pull/90128/files#diff-0b2c86f706e4bcb3ab0cfaaf6cc7a6cee303d02b59c9b11a6af847eb5916aedbR11

[dgieselaar]

@elasticmachine merge upstream

[dgieselaar]

I've fixed the issue with the runtime type, converted comparisonType to use an enum and change the labels from yesterday/a week ago to day before/week before. Additionally I fixed a bug where the throughput value for the charts was not correct because it was divided by the entire time range instead of the bucket size (not related to this PR). I'll merge this when CI is green.

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 8b587d6

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
apm	1730	1731	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
apm	5.2MB	5.2MB	+3.0KB

History

• 💚 Build #106381 succeeded 6bb696e
• 💔 Build #106366 failed f5695cd
• 💚 Build #106341 succeeded 2720921
• 💛 Build #105246 was flaky 1331535
• 💚 Build #105077 succeeded c656821

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[kibanamachine]

Backport result

{"level":"info","message":"POST https://api.github.com/graphql (status: 200)"}
{"level":"info","message":"POST https://api.github.com/graphql (status: 200)"}
{"meta":{"labels":["Team:apm","apm:comparison","auto-backport","release_note:skip","v7.12.0","v8.0.0"],"branchLabelMapping":{"^v8.0.0$":"master","^v7.12.0$":"7.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"},"existingTargetPullRequests":[]},"level":"info","message":"Inputs when calculating target branches:"}
{"meta":["7.x"],"level":"info","message":"Target branches inferred from labels:"}
{"meta":{"killed":false,"code":2,"signal":null,"cmd":"git remote rm kibanamachine","stdout":"","stderr":"error: No such remote: 'kibanamachine'\n"},"level":"info","message":"exec error 'git remote rm kibanamachine':"}
{"meta":{"killed":false,"code":2,"signal":null,"cmd":"git remote rm elastic","stdout":"","stderr":"error: No such remote: 'elastic'\n"},"level":"info","message":"exec error 'git remote rm elastic':"}
{"level":"info","message":"Backporting [{\"sourceBranch\":\"master\",\"targetBranchesFromLabels\":[\"7.x\"],\"sha\":\"874fadf388eed6fc43dde79e74698158b5245398\",\"formattedMessage\":\"[APM] Adding comparison to throughput chart (#90128)\",\"originalMessage\":\"[APM] Adding comparison to throughput chart (#90128)\\n\\nCo-authored-by: Kibana Machine <[email protected]>\\r\\nCo-authored-by: Dario Gieselaar <[email protected]>\",\"pullNumber\":90128,\"existingTargetPullRequests\":[]}] to 7.x"}

Backporting to 7.x:
{"level":"info","message":"Backporting via filesystem"}
{"meta":{"killed":false,"code":1,"signal":null,"cmd":"git cherry-pick 874fadf388eed6fc43dde79e74698158b5245398","stdout":"Auto-merging x-pack/plugins/apm/server/routes/services.ts\nCONFLICT (content): Merge conflict in x-pack/plugins/apm/server/routes/services.ts\nAuto-merging x-pack/plugins/apm/server/lib/services/get_throughput.ts\nCONFLICT (content): Merge conflict in x-pack/plugins/apm/server/lib/services/get_throughput.ts\nAuto-merging x-pack/plugins/apm/server/lib/helpers/setup_request.ts\nCONFLICT (content): Merge conflict in x-pack/plugins/apm/server/lib/helpers/setup_request.ts\nAuto-merging x-pack/plugins/apm/public/context/url_params_context/types.ts\nAuto-merging x-pack/plugins/apm/public/context/url_params_context/resolve_url_params.ts\nRemoving x-pack/plugins/apm/common/runtime_types/date_as_string_rt/index.test.ts\n","stderr":"error: could not apply 874fadf388e... [APM] Adding comparison to throughput chart (#90128)\nhint: after resolving the conflicts, mark the corrected paths\nhint: with 'git add <paths>' or 'git rm <paths>'\nhint: and commit the result with 'git commit'\n"},"level":"info","message":"exec error 'git cherry-pick 874fadf388eed6fc43dde79e74698158b5245398':"}
{"meta":{"killed":false,"code":2,"signal":null,"cmd":"git --no-pager diff --check","stdout":"x-pack/plugins/apm/server/lib/helpers/setup_request.ts:112: leftover conflict marker\nx-pack/plugins/apm/server/lib/helpers/setup_request.ts:118: leftover conflict marker\nx-pack/plugins/apm/server/lib/helpers/setup_request.ts:125: leftover conflict marker\nx-pack/plugins/apm/server/lib/services/get_throughput.ts:19: leftover conflict marker\nx-pack/plugins/apm/server/lib/services/get_throughput.ts:22: leftover conflict marker\nx-pack/plugins/apm/server/lib/services/get_throughput.ts:25: leftover conflict marker\nx-pack/plugins/apm/server/lib/services/get_throughput.ts:90: leftover conflict marker\nx-pack/plugins/apm/server/lib/services/get_throughput.ts:95: leftover conflict marker\nx-pack/plugins/apm/server/lib/services/get_throughput.ts:109: leftover conflict marker\nx-pack/plugins/apm/server/routes/services.ts:23: leftover conflict marker\nx-pack/plugins/apm/server/routes/services.ts:24: leftover conflict marker\nx-pack/plugins/apm/server/routes/services.ts:32: leftover conflict marker\nx-pack/plugins/apm/server/routes/services.ts:248: leftover conflict marker\nx-pack/plugins/apm/server/routes/services.ts:261: leftover conflict marker\nx-pack/plugins/apm/server/routes/services.ts:277: leftover conflict marker\n","stderr":""},"level":"info","message":"exec error 'git --no-pager diff --check':"}
Commit could not be cherrypicked due to conflicts