-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Correlations Beta (#86477) #89952
Merged
Merged
Changes from 22 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
d321f85
[APM] Correlations GA (#86477)
ogupte 9110ffa
polish and improvements to correlations UI
ogupte 63da7e6
more improvements and polish
ogupte d93f4ca
added impact bar
ogupte 711bfe6
added descriptions
ogupte 38d6a61
make custom field persistence be unique per service
ogupte c535b4a
make custom threshold unique per service in latency correlations
ogupte 3fece27
adds telemetry for apm correlations feature. Events:
ogupte c52deb3
adds more telemetry for correlations (#90622)
ogupte 906cb6d
removes the raw score column
ogupte 185bfe6
replaces experiemental callout with beta badge
ogupte 1c99c5c
replaces threshold number input with percentile option selector
ogupte 6a0b5e0
improvements to latency correlations scoring and percentage reporting
ogupte f878301
Merge branch 'master' into apm-86477-correlations-ga
ogupte 54ff95d
Merge branch 'master' into apm-86477-correlations-ga
ogupte 30b188c
removes the 'apm:enableCorrelations' UI setting
ogupte 429bc7b
- rename useFieldNames.ts -> use_field_names.ts
ogupte cab10a2
Fixes casing issue for the 'correlations' dir
ogupte 0f09c0b
[APM] Moves correlations button to service details tabslist row (#91080)
ogupte b5f69ab
[APM] Adds license check for correlations (#90766)
ogupte cd3407e
[APM] Adds metrics tracking for correlations views and license prompt…
ogupte 7eae6b9
Updated the API integration tests to check for new default fields and…
ogupte 50cd63a
Merge branch 'master' into apm-86477-correlations-ga
kibanamachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
108 changes: 0 additions & 108 deletions
108
x-pack/plugins/apm/public/components/app/Correlations/index.tsx
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, You'd need to open a corresponding mapping update request in the infra repo to have this key removed from the telemetry mappings.
If you don't care that it's not there in versions from 7.12, then you won't need to open an issue for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll probably remove it from the mapping in the infra repo in 7.13. That way we'll be able to tell if users are still using it as a custom UI Setting for version 7.12.