[Upgrade Assistant] Fixes to Upgrade Assistant Tests and Page Objects To Stop CI Failures #89942
Conversation
…o CI failures. Expect functions should be in the test file itself so I changed the page objects for page actions and extracted out the expect calls to the test files.
cuff-links
added
test_xpack_functional
v8.0.0
Team:Kibana Management
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
|
@elasticmachine merge upstream |
… pass on the first attempt. Simplified the toggle function to just click the toggle.
|
@elasticmachine merge upstream |
There was a problem hiding this comment.
Thanks for working on this @cuff-links! Changes LGTM. I ran once locally and all tests passed.
Were you planning on running this multiple times in CI to confirm it addresses the flakiness?
Yep. In the process of setting that up. |
|
jenkins test this |
|
@elasticmachine Merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
|
Ran via flakey test runner. https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1211/ |
… To Stop CI Failures (elastic#89942) * Updated test to use no hard coded waits which could be contributing to CI failures. Expect functions should be in the test file itself so I changed the page objects for page actions and extracted out the expect calls to the test files. * Added retry within the test file to retry the assertion if it doesn't pass on the first attempt. Simplified the toggle function to just click the toggle. * Fixed type check issue. Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/test/functional/apps/upgrade_assistant/upgrade_assistant.ts
…bjects To Stop CI Failures (#89942) (#90387) * [Upgrade Assistant] Fixes to Upgrade Assistant Tests and Page Objects To Stop CI Failures (#89942) * Updated test to use no hard coded waits which could be contributing to CI failures. Expect functions should be in the test file itself so I changed the page objects for page actions and extracted out the expect calls to the test files. * Added retry within the test file to retry the assertion if it doesn't pass on the first attempt. Simplified the toggle function to just click the toggle. * Fixed type check issue. Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/test/functional/apps/upgrade_assistant/upgrade_assistant.ts * Removed an unused reference to security.
| expect(summaryElText).to.eql(summary); | ||
| async waitForTelemetryHidden() { | ||
| const self = this; | ||
| retry.waitFor('Telemetry to disappear.', async () => { |
There was a problem hiding this comment.
I'm seeing failures like https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/104171/execution/node/796/log/
What seems to happen is that tests pass and complete, so the test runner kills the kibana process. However webdriver is still stuck in this waitFor and so exits with a non-zero code.
I suspect we need to insert an await here await retry.waitFor('... so that we don't end the test and kill Kibana before webdriver is done.
There was a problem hiding this comment.
Closes #52360
Closes #52465
Summary
This PR addresses issues that could be contributing to the intermittent failing of Upgrade Assistant functional tests.
As part of this PR we:
retry.trycalls forretry.waitFor()when we had a concrete condition to wait for.expected()calls to test files which is in line with the rest of our tests.