Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrates watcher to a TS project ref #89622

Merged
merged 3 commits into from
Jan 29, 2021
Merged

Migrates watcher to a TS project ref #89622

merged 3 commits into from
Jan 29, 2021

Conversation

TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented Jan 28, 2021 •
edited
Loading

Summary

Partially resolves #89321

tsc compiler performance with running node --max-old-space-size=4096 ./node_modules/.bin/tsc -p x-pack/tsconfig.json --extendedDiagnostics --noEmit

** Before
Files: 16973
Lines: 1865222

** After
Files: 16658
Lines: 1851711

@TinaHeiligers TinaHeiligers added chore v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Jan 28, 2021
@TinaHeiligers TinaHeiligers requested a review from a team as a code owner January 28, 2021 19:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@TinaHeiligers TinaHeiligers mentioned this pull request Jan 28, 2021
Closed
@TinaHeiligers TinaHeiligers marked this pull request as draft January 28, 2021 19:13
@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers marked this pull request as ready for review January 28, 2021 23:28
@TinaHeiligers
Copy link
Contributor Author

cc @elastic/kibana-core

sebelga
sebelga approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @TinaHeiligers

@TinaHeiligers TinaHeiligers merged commit 5c45e7d into elastic:master Jan 29, 2021
@TinaHeiligers TinaHeiligers deleted the ts-project-refs-es_ui/watcher-migration branch January 29, 2021 14:48
TinaHeiligers added a commit to TinaHeiligers/kibana that referenced this pull request Jan 29, 2021
@TinaHeiligers @kibanamachine
Migrates watcher to a TS project ref (elastic#89622)
2dc42cd 
Co-authored-by: Kibana Machine <[email protected]>
@TinaHeiligers TinaHeiligers mentioned this pull request Jan 29, 2021
Merged
TinaHeiligers added a commit that referenced this pull request Jan 29, 2021
@TinaHeiligers @kibanamachine
[7.x] Migrates watcher to a TS project ref (#89622) (#89725)
9e8451a 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bamieh Bamieh Bamieh approved these changes

@sebelga sebelga sebelga approved these changes

Assignees
No one assigned
Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Meta] Migrate plugins to TS references for es_ui CODEOWNERS plugins
5 participants
@TinaHeiligers @elasticmachine @kibanamachine @sebelga @Bamieh