-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[load testing] add env vars to pass simulations and repo rootPath #89544
[load testing] add env vars to pass simulations and repo rootPath #89544
Conversation
Ok, the code looks good. Ill try to run it now. |
x-pack/test/load/runner.ts
Outdated
], | ||
cwd: gatlingProjectRootPath, | ||
env: { | ||
...process.env, | ||
}, | ||
wait: true, | ||
}); | ||
for (const simulationClass of simulations.split(',').filter((i) => i.length > 0)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: This could be a named fn:
const dropEmptyLines = x => x.split(',').filter(i => i.length > 0);
for (const simulationClass of dropEmptyLines(simulations)) {
...
Not a big deal at all, just a "nit pick" lol.
@dmlemeshko I tried running it from x-pack and I got errors again. Ideas? |
@wayneseymour did you checkout load-testing repo with the latest master next to kibana repo? |
@elasticmachine merge upstream |
dfaaa20
to
586d9c6
Compare
className.replace('.', '/') + simulationFIleExtension | ||
); | ||
if (!Fs.existsSync(simulationClassPath)) { | ||
throw createFlagError(`Simulation class is not found: '${simulationClassPath}'`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice!
I do believe so, but I'll try again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
│ info [o.e.x.w.WatcherLifeCycleService] [les.local] watcher has stopped and shutdown
│ info [o.e.n.Node] [les.local] stopped
│ info [o.e.n.Node] [les.local] closing ...
│ info [o.e.n.Node] [les.local] closed
│ info [es] stopped
│ info [es] cleanup complete
LGTM!
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack Reporting API Integration Tests.x-pack/test/reporting_api_integration/reporting_and_security/csv_job_params·ts.Reporting APIs Generation from Job Params "before all" hook for "Rejects bogus jobParams"Standard Out
Stack Trace
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
3 similar comments
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
6 similar comments
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
…astic#89544) * [load testing] add env vars to pass simulations and repo rootPath * pass simulation to sript as argument * export GATLING_SIMULATIONS * fix export * add validation
Summary
Closes elastic/kibana-load-testing/issues/40
It is possible to run custom simulations via FTR:
multiple simulations:
Simulation class should exist in simulation package
Checklist
Delete any items that are not applicable to this PR.
For maintainers