[coverage] fix jest report merging #89537
Conversation
| def ARTIFACT_PATTERNS = [ | ||
| 'target/junit/**/*', | ||
| 'target/kibana-*', | ||
| 'target/kibana-coverage/**/*', | ||
| 'target/kibana-coverage/jest/**/*', |
There was a problem hiding this comment.
We don't want to upload content of target/kibana-coverage/functional since it is 2-10 GB and we archive it here
kibana/vars/kibanaPipeline.groovy
Lines 219 to 223 in 2494b24
dmlemeshko
added
backport:skip
| # Need to override COVERAGE_INGESTION_KIBANA_ROOT since json file has original intake worker path | ||
| COVERAGE_SUMMARY_FILE=target/kibana-coverage/jest-combined/coverage-summary.json | ||
| export COVERAGE_INGESTION_KIBANA_ROOT=/dev/shm/workspace/kibana | ||
| node scripts/ingest_coverage.js --verbose --path ${COVERAGE_SUMMARY_FILE} --vcsInfoPath ./VCS_INFO.txt --teamAssignmentsPath $TEAM_ASSIGN_PATH |
There was a problem hiding this comment.
Why duplicate instead of loop?
There was a problem hiding this comment.
Line #43 is specific for jest, I thought about loop + if but then decided to do it this way
There was a problem hiding this comment.
@wayneseymour do you want me to change it with for+if ?
There was a problem hiding this comment.
Nah it's all good. I just keep a lookout for duplication.
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
|
@dmlemeshko, not sure if this is still needed - as the original PR was reverted - and re-merged without changing any of the code coverage information. |
|
Closing in favour of #90915 |
Summary
This PR fixes code coverage merge for jest: we merge it right after
jestandjest-integrationtests are finished and upload reports to GCS.Tested: https://kibana-ci.elastic.co/job/elastic+kibana+qa-research/182/