Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include invalid types in a d.ts file to make sure they are caught by CI #89349

Closed
wants to merge 4 commits into from

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jan 26, 2021

Testing that invalid types in .d.ts files are still caught by CI after #89333

@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 26, 2021

💔 Build Failed

Failed CI Steps


Test Failures

Jest Tests.src/setup_node_env.NodeVersionValidator should run the script WITHOUT error

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

Error: thrown: "Exceeded timeout of 5000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."
    at /dev/shm/workspace/parallel/2/kibana/src/setup_node_env/node_version_validator.test.js:32:3
    at _dispatchDescribe (/dev/shm/workspace/kibana/node_modules/jest-circus/build/index.js:67:26)
    at describe (/dev/shm/workspace/kibana/node_modules/jest-circus/build/index.js:30:5)
    at Object.<anonymous> (/dev/shm/workspace/parallel/2/kibana/src/setup_node_env/node_version_validator.test.js:15:1)
    at Runtime._execModule (/dev/shm/workspace/kibana/node_modules/jest-runtime/build/index.js:1299:24)
    at Runtime._loadModule (/dev/shm/workspace/kibana/node_modules/jest-runtime/build/index.js:898:12)
    at Runtime.requireModule (/dev/shm/workspace/kibana/node_modules/jest-runtime/build/index.js:746:10)
    at jestAdapter (/dev/shm/workspace/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:106:13)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at runTestInternal (/dev/shm/workspace/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/dev/shm/workspace/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/dev/shm/workspace/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.8MB 1.8MB +2.0B
graph 1.2MB 1.2MB +27.0B
securitySolution 7.5MB 7.5MB +27.0B
total +56.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
upgradeAssistant 57.6KB 57.6KB +2.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger closed this Jan 26, 2021
@spalger spalger deleted the pr/89333 branch February 13, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants