-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Case] Add the ability to mark cases in progress in cases table. #89341
Conversation
c299ec2
to
9611eef
Compare
9611eef
to
37f7565
Compare
Pinging @elastic/security-solution (Team: SecuritySolution) |
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
disabled={selectedCaseIds.length === 0} | ||
key="cases-bulk-open-button" | ||
icon={statuses[CaseStatuses.open].icon} | ||
onClick={() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please put into useCallback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get this error. I think is ok to leave it as it is as I have refactor to make it work.
React Hook "useCallback" is called in function "getBulkItems" that is neither a React function component nor a custom React Hook function. React component names must start with an uppercase letter.
disabled={selectedCaseIds.length === 0} | ||
key="cases-bulk-close-button" | ||
icon={statuses[CaseStatuses.closed].icon} | ||
onClick={() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please put into useCallback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need a few useCallbacks, other than that LGTM! Good job @cnasikas 🚀
@elasticmachine merge upstream |
c19f73b
to
8258ce2
Compare
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Summary
PR #84321 added the
in-progress
status. The UI in all cases page does not offer the ability to the user to change the status of the case toin-progress
. This PR adds this functionality.Status icon:
Open:
folderOpen
In progress:
folderExclamation
Closed:
folderClosed
All cases: Status open
All cases: Status in progress
All cases: Status in closed
Demo
Add.in.progress.mp4
Checklist
Delete any items that are not applicable to this PR.
For maintainers