-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate and remove usages of elasticsearch.logQueries #89296
Conversation
d2f0ed6
to
eace603
Compare
eace603
to
e303ca7
Compare
e303ca7
to
f6553be
Compare
Pinging @elastic/kibana-core (Team:Core) |
src/core/server/elasticsearch/legacy/elasticsearch_client_config.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was /plugins/.empty
unintentionally deleted here?
Somehow, this has happened to me twice now. Not sure what is doing this. Anyways, I put it back, thanks for catching. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Could you add an example how to reproduce the old default behaviour?
logging:
loggers:
- context: elasticsearch.query
level: off
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome UI Functional Tests.test/functional/apps/dashboard/dashboard_state·ts.dashboard app new charts library dashboard state "before all" hook for "Overriding colors on an area chart is preserved"Standard Out
Stack Trace
Kibana Pipeline / general / Chrome UI Functional Tests.test/functional/apps/dashboard/dashboard_state·ts.dashboard app new charts library dashboard state "after all" hook for "Tile map with no changes will update with visualization changes"Standard Out
Stack Trace
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
#89879) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Summary
Closes #57546
This PR makes the following changes
elasticsearch.logQueries
completelydebug
elasticsearch.query
Release Note
The
elasticsearch.logQueries
config is now deprecated. Elasticsearch query logs will now always be shown whenlogging.verbose: true
orlogging.root.level: 'debug'
is set. Prior to this change, Elasticsearch query logs would not be included in verbose logging unlesselasticsearch.logQueries
was set. In order to use verbose logging without Elasticsearch query logs, you can set the query logs to off in kibana.yml:Kibana 8.0 will fail to start up if
elasticsearch.logQueries: true
is set. It is recommended that users remove this setting after successfully upgrading to Kibana 7.12.Checklist
Delete any items that are not applicable to this PR.
For maintainers