Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify 7.10 changelog by adding product tags #88731

Merged
merged 3 commits into from
Jan 20, 2021
Merged

Conversation

wylieconlon
Copy link
Contributor

@wylieconlon wylieconlon commented Jan 19, 2021

It seems like the release notes removed the product tags that we add, like [TSVB] or [Lens]- these tags are required to understand the change. I've added them back in here.

@wylieconlon wylieconlon changed the base branch from 7.10 to master January 19, 2021 18:48
@wylieconlon wylieconlon changed the base branch from master to 7.x January 19, 2021 19:00
@wylieconlon wylieconlon force-pushed the clarify-7.10-changelog branch from 0e2addf to 83935af Compare January 19, 2021 19:04
@wylieconlon wylieconlon added v7.10.0 v7.11.0 v7.12.0 Team:Docs release_note:skip Skip the PR/issue when compiling release notes labels Jan 19, 2021
@wylieconlon wylieconlon marked this pull request as ready for review January 19, 2021 19:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [012b6fe]

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@wylieconlon
Copy link
Contributor Author

@elasticmachine merge upstream

@wylieconlon
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this because I think you're right, users do scan for the specific visualization editors in the RN. I always remove the tags because our RN items should start with Adds, Fixes, etc. I'll implement the editor names into the titles for future releases.

@wylieconlon wylieconlon merged commit 4a5ac55 into 7.x Jan 20, 2021
@wylieconlon wylieconlon deleted the clarify-7.10-changelog branch January 20, 2021 23:46
wylieconlon pushed a commit to wylieconlon/kibana that referenced this pull request Jan 20, 2021
wylieconlon pushed a commit that referenced this pull request Jan 21, 2021
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
wylieconlon pushed a commit that referenced this pull request Jan 21, 2021
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.10.0 v7.11.0 v7.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants