-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security_Solution][Resolver] Fix Text Overflow #88679
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelolo24
added
bug
Fixes for quality problems that affect the customer experience
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
Feature:Resolver
Security Solution Resolver feature
v7.11.0
Team:Threat Hunting
Security Solution Threat Hunting Team
labels
Jan 19, 2021
Pinging @elastic/endpoint-app-team (Feature:Resolver) |
💛 Build succeeded, but was flaky
Test FailuresX-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/rbac_legacy·ts.alerting api integration security and spaces enabled Alerts legacy alerts alerts "before all" hook in "alerts"Standard Out
Stack Trace
X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/rbac_legacy·ts.alerting api integration security and spaces enabled Alerts legacy alerts alerts "after all" hook in "alerts"Standard Out
Stack Trace
X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/index·ts.alerting api integration security and spaces enabled Alerts legacy alerts "after all" hook in "legacy alerts"Standard Out
Stack Trace
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
jonathan-buttner
approved these changes
Jan 19, 2021
kqualters-elastic
approved these changes
Jan 19, 2021
michaelolo24
added a commit
to michaelolo24/kibana
that referenced
this pull request
Jan 19, 2021
michaelolo24
added a commit
to michaelolo24/kibana
that referenced
this pull request
Jan 19, 2021
michaelolo24
added a commit
that referenced
this pull request
Jan 20, 2021
Co-authored-by: Kibana Machine <[email protected]>
michaelolo24
added a commit
that referenced
this pull request
Jan 20, 2021
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Resolver
Security Solution Resolver feature
release_note:skip
Skip the PR/issue when compiling release notes
Team:Threat Hunting
Security Solution Threat Hunting Team
v7.11.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previous fix here: #86905, was incorrect: This PR fixes: elastic/eui#6277 by using
EuiBreadcrumb
's truncate functionalityExamples of non-spaced text truncation: