Prevent excessive ES version warnings #8865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
reviewed
Oct 27, 2016
| sinon.assert.callCount(server.log, 4); | ||
| expect(server.log.getCall(2).args[0]).to.contain('debug'); | ||
| expect(server.log.getCall(3).args[0]).to.contain('warning'); | ||
| }); |
|
I marked this as a 5.0.1 as well - it's a pretty big deal from an operational perspective if we're spamming logs with unnecessary data, especially when you consider things like multi-tenant setups. |
cjcenizal
approved these changes
Oct 27, 2016
| getHumanizedNodeNames, | ||
| nodes: simplifiedNodes, | ||
| }); | ||
| const warningNodeNames = getHumanizedNodeNames(simplifiedNodes).join(', '); |
There was a problem hiding this comment.
Can we add a comment?
// Don't show the same warning over and over again.| nodes: simplifiedNodes, | ||
| }); | ||
| const warningNodeNames = getHumanizedNodeNames(simplifiedNodes).join(', '); | ||
| if (lastWarnedAboutNodes.get(server) !== warningNodeNames) { |
There was a problem hiding this comment.
Is server a reference to the same object every time this function is called? If so maybe a weakMap is overkill, and we just cache a reference with a regular variable, e.g. prevWarningNodeNames !== warningNodeNames.
There was a problem hiding this comment.
Not in multi-tenancy situations
cjcenizal
reviewed
Oct 27, 2016
| }); | ||
| // Don't show the same warning over and over again. | ||
| const warningNodeNames = getHumanizedNodeNames(simplifiedNodes).join(', '); | ||
| if (lastWarnedNodesForServer.get(server) !== warningNodeNames) { |
There was a problem hiding this comment.
Probably worth some sort of comment here about how multi-tenancy comes into play... if it's written in a way so that even I can understand it, then it's a foolproof comment. :)
There was a problem hiding this comment.
Or maybe such a comment belongs where lastWarnedNodesForServer is defined.
|
One comment above, LGTM otherwise. |
spalger
changed the title
elastic-jasper
added a commit
that referenced
this pull request
Oct 28, 2016
--------- **Commit 1:** [es/versionCheck] prevent spamming logs with compatibility warnings * Original sha: bb95cf8 * Authored by spalger <[email protected]> on 2016-10-27T20:48:36Z **Commit 2:** [es/versionCheck] clarify new var and reason for check * Original sha: cda9594 * Authored by spalger <[email protected]> on 2016-10-27T22:36:43Z **Commit 3:** [es/versionCheck] explain why we need to track per-server * Original sha: 5eb9ccd * Authored by spalger <[email protected]> on 2016-10-27T23:30:41Z
elastic-jasper
added a commit
that referenced
this pull request
Oct 28, 2016
--------- **Commit 1:** [es/versionCheck] prevent spamming logs with compatibility warnings * Original sha: bb95cf8 * Authored by spalger <[email protected]> on 2016-10-27T20:48:36Z **Commit 2:** [es/versionCheck] clarify new var and reason for check * Original sha: cda9594 * Authored by spalger <[email protected]> on 2016-10-27T22:36:43Z **Commit 3:** [es/versionCheck] explain why we need to track per-server * Original sha: 5eb9ccd * Authored by spalger <[email protected]> on 2016-10-27T23:30:41Z
This was referenced Oct 28, 2016
spalger
pushed a commit
that referenced
this pull request
Oct 28, 2016
--------- **Commit 1:** [es/versionCheck] prevent spamming logs with compatibility warnings * Original sha: bb95cf8 * Authored by spalger <[email protected]> on 2016-10-27T20:48:36Z **Commit 2:** [es/versionCheck] clarify new var and reason for check * Original sha: cda9594 * Authored by spalger <[email protected]> on 2016-10-27T22:36:43Z **Commit 3:** [es/versionCheck] explain why we need to track per-server * Original sha: 5eb9ccd * Authored by spalger <[email protected]> on 2016-10-27T23:30:41Z
spalger
pushed a commit
that referenced
this pull request
Oct 28, 2016
--------- **Commit 1:** [es/versionCheck] prevent spamming logs with compatibility warnings * Original sha: bb95cf8 * Authored by spalger <[email protected]> on 2016-10-27T20:48:36Z **Commit 2:** [es/versionCheck] clarify new var and reason for check * Original sha: cda9594 * Authored by spalger <[email protected]> on 2016-10-27T22:36:43Z **Commit 3:** [es/versionCheck] explain why we need to track per-server * Original sha: 5eb9ccd * Authored by spalger <[email protected]> on 2016-10-27T23:30:41Z
nreese
pushed a commit
to nreese/kibana
that referenced
this pull request
Nov 10, 2016
* [es/versionCheck] prevent spamming logs with compatibility warnings * [es/versionCheck] clarify new var and reason for check * [es/versionCheck] explain why we need to track per-server
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
--------- **Commit 1:** [es/versionCheck] prevent spamming logs with compatibility warnings * Original sha: bb95cf8 * Authored by spalger <[email protected]> on 2016-10-27T20:48:36Z **Commit 2:** [es/versionCheck] clarify new var and reason for check * Original sha: cda9594 * Authored by spalger <[email protected]> on 2016-10-27T22:36:43Z **Commit 3:** [es/versionCheck] explain why we need to track per-server * Original sha: 5eb9ccd * Authored by spalger <[email protected]> on 2016-10-27T23:30:41Z Former-commit-id: 236557b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warnings are currently spamming the log if we detect a possible compatibility issue, repeating the same warning on every health check