Spinner performance. Use translate instead of positioning. #8842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rashidkpc this has 5.1.0 label but was not backported to 5.1 (or 5.x) |
|
@ppisljar it is, the commit hash is different |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the pink spinner bar at the top from using background positioning of the element to use CSS transforms, thus offloading the spinner animation to the GPU and removing the need to render & paint. There's no functionality change here, this is just a performance tweak.
While the pies below make the gain seem minimal, this change takes my CPU from a steady 30% while the spinner is active, down to 17%. Its a pretty big win when you have a breakpoint set and the spinner is running.
Before:
After:
