[chrome/nav] allow link properties to change over time #8837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation uses Array#filter() to produce a list of "shown links", this changes it to a live filter with `ng-if` that will update the view, should the hidden property of the link change over time
elastic-jasper
added a commit
that referenced
this pull request
Oct 25, 2016
--------- **Commit 1:** [chrome/nav] allow link properties to change over time The current implementation uses Array#filter() to produce a list of "shown links", this changes it to a live filter with `ng-if` that will update the view, should the hidden property of the link change over time * Original sha: e80ad49 * Authored by spalger <[email protected]> on 2016-10-25T20:23:38Z
spalger
added a commit
that referenced
this pull request
Oct 25, 2016
[backport] PR #8837 to 5.x - [chrome/nav] allow link properties to change over time
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
--------- **Commit 1:** [chrome/nav] allow link properties to change over time The current implementation uses Array#filter() to produce a list of "shown links", this changes it to a live filter with `ng-if` that will update the view, should the hidden property of the link change over time * Original sha: d68c85796f26704535815888d415a3244bb5ea89 [formerly e80ad49] * Authored by spalger <[email protected]> on 2016-10-25T20:23:38Z Former-commit-id: 32432d5
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[backport] PR elastic#8837 to 5.x - [chrome/nav] allow link properties to change over time Former-commit-id: df18307
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation uses Array#filter() to produce a list of "shown links", this changes it to a live filter with
ng-ifthat will update the view, should the hidden property of the link change over time