-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Case] Fix patch cases integration test with alerts #88311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnasikas
force-pushed
the
fix_failing_test
branch
from
January 14, 2021 15:59
0c71590
to
5da167c
Compare
cnasikas
changed the title
[Security Solution][Case][skip-ci] Fix patch cases integration test with alerts
[Security Solution][Case] Fix patch cases integration test with alerts
Jan 15, 2021
cnasikas
force-pushed
the
fix_failing_test
branch
from
January 15, 2021 08:40
5da167c
to
9d8f2c2
Compare
cnasikas
added
v7.11.0
v7.12.0
v8.0.0
bug
Fixes for quality problems that affect the customer experience
release_note:skip
Skip the PR/issue when compiling release notes
labels
Jan 15, 2021
cnasikas
added
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Team:Threat Hunting
Security Solution Threat Hunting Team
labels
Jan 15, 2021
spalger
approved these changes
Jan 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
This was referenced Jan 18, 2021
cnasikas
added a commit
to cnasikas/kibana
that referenced
this pull request
Jan 18, 2021
elastic#88311) Co-authored-by: Kibana Machine <[email protected]>
cnasikas
added a commit
to cnasikas/kibana
that referenced
this pull request
Jan 18, 2021
elastic#88311) Co-authored-by: Kibana Machine <[email protected]>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 18, 2021
* master: (33 commits) [Security Solution][Case] Fix patch cases integration test with alerts (elastic#88311) [Security Solutions][Detection Engine] Removes duplicate API calls (elastic#88420) Fix log msg (elastic#88370) [Test] Add tag cloud visualization to dashboard in functional test for reporting (elastic#87600) removing kibana-core-ui from codeowners (elastic#88111) [Alerting] Migrate Event Log plugin to TS project references (elastic#81557) [Maps] fix zooming while drawing shape filter logs errors in console (elastic#88413) Porting fixes 1 (elastic#88477) [APM] Explicitly set environment for cross-service links (elastic#87481) chore(NA): remove mocha junit ci integrations (elastic#88129) [APM] Only display relevant sections for rum agent in service overview (elastic#88410) [Enterprise Search] Automatically mock shared logic files (elastic#88494) [APM] Disable Create custom link button on Transaction details page for read-only users [Docs] clean-up vega map reference documenation (elastic#88487) [Security Solution] Fix Timeline event details layout (elastic#88377) Change DELETE to POST for _bulk_delete to avoid incompatibility issues (elastic#87914) [Monitoring] Change cloud messaging on no data page (elastic#88375) [Uptime] clear ping state when PingList component in unmounted (elastic#88321) [APM] Consistent terminology for latency and throughput (elastic#88452) fix copy (elastic#88481) ...
cnasikas
added a commit
that referenced
this pull request
Jan 19, 2021
…h alerts (#88311) (#88573) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
cnasikas
added a commit
that referenced
this pull request
Jan 19, 2021
#88311) (#88572) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
release_note:skip
Skip the PR/issue when compiling release notes
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Team:Threat Hunting
Security Solution Threat Hunting Team
v7.11.0
v7.12.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I unskiped the tests and performed a stress test. Results: Executions: 42, Failures: 3.
This showed that a change in the status of an alert takes time to be populated across all ES nodes.
When there is a status change on a case and the sync alerts option is on, then all alerts attach to a case must change their status to match the case's status. This is done as:
Because we do not set the
refresh
option, for examplerefresh: 'true'
, the request is fulfilled but changes made by this request will be made visible at some point after the request returns.Because setting the refresh to true could lead to a poor performance we decided to skip the tests and find a better solution to tackle the problem.
I performing another stress test with those tests skipped. Results: Executions: 42, Failures: 0
Fixes: #87988
Fixes: #88130
Reference: #88432
Checklist
Delete any items that are not applicable to this PR.
For maintainers