Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Cleanup: Remove isValidCoordinateValue and getResponseTimeTooltipFormatter #87836

Merged
merged 1 commit into from
Jan 11, 2021
Merged

[APM] Cleanup: Remove isValidCoordinateValue and getResponseTimeTooltipFormatter #87836

merged 1 commit into from
Jan 11, 2021

Conversation

sorenlouv
Copy link
Member

  • Remove isValidCoordinateValue and getResponseTimeTooltipFormatter
  • Add fallback value to asDecimal and asInteger to align with other formatters

@sorenlouv sorenlouv requested a review from a team as a code owner January 11, 2021 13:59
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jan 11, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1735 1734 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.4MB 5.4MB -909.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv added release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Jan 11, 2021
@sorenlouv sorenlouv merged commit 7cd1fa3 into elastic:master Jan 11, 2021
@sorenlouv sorenlouv deleted the minor-cleanup branch January 11, 2021 22:43
@sorenlouv sorenlouv mentioned this pull request Jan 11, 2021
Merged
sorenlouv added a commit that referenced this pull request Jan 12, 2021
@sorenlouv
[7.x] [APM] Cleanup: Remove isValidCoordinateValue and `getResponse…
065c033 
…TimeTooltipFormatter` (#87836) (#87941)
@sorenlouv sorenlouv mentioned this pull request Jan 15, 2021
Merged
sorenlouv added a commit that referenced this pull request Jan 15, 2021
@sorenlouv
[7.11] [APM] Cleanup: Remove isValidCoordinateValue and `getRespons…
25c0810 
…eTimeTooltipFormatter` (#87836) (#88433)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgieselaar dgieselaar dgieselaar approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sorenlouv @elasticmachine @kibanamachine @dgieselaar