[ILM] Absolute to relative time conversion

[jloleysens]

Summary

Added lib logic for converting an ILM policy's minimum age timings to relative time. For example:

// policy
{
  hot: { min_age: '0ms' },
  warm: { min_age: '2d' },
  cold: { min_age: '15d' },
  delete: { min_age: '1M' },
}
// =>
{
  total: 'At least 30 days', // This copy is intended to be visible to users
  hot: 'At least 2 days',
  warm: 'At least 13 days',
  cold: 'At least 17 days',,
}

Additionally, the lib code includes a function for returning these values in their millisecond form, see the test coverage for examples of how the returned values look.

How to review

The code added is just lib code, it is not consumed anywhere except for the accompanying tests. These should be read and expanded in the review to make sure that we are correctly handling absolute time conversion to relative time conversion.

The goal of this code is to give users an understanding of how long their data will be in any given phase, and by extension any given data tier.

The assumption was made to always use "day" as the unit of time for this output to simplify the copy and create uniformity in the information being conveyed.

Note

Also removed some unused, legacy logic and types in 9dfe2fc

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Unit or functional tests were updated or added to match the most common scenarios

[elasticmachine]

Pinging @elastic/es-ui (Team:Elasticsearch UI)

[jloleysens]

@elasticmachine merge upstream

[yuliacech]

Hi @jloleysens , thanks a lot for working on this conversion! I appreciate addition of tests and build-in i18n support, however I think having this lib function return durations in days (Infinity for forever, fractions for less than a day) would be easier for UI integration than i18n strings. For example, change color and icon of phase duration bottom block if duration < Infinity

[jloleysens]

@elasticmachine merge upstream

[jloleysens]

Thanks for the review @yuliacech , I've changed the lib to also export another function that returns the millisecond values per phase. This is definitely something that will be useful for the timeline component and possibly in other places too!

I also expanded the test coverage to this new function.

Would you mind taking another look when you get a chance? See 5158ae9.

[jloleysens]

@elasticmachine merge upstream

[yuliacech]

Thanks for working on this, @jloleysens ! Changes LGTM, left a couple of nits in comments, but nothing blocking 👍

[yuliacech]

nit: I think we should use a lowercase 'forever' for both the label and the string itself

[yuliacech]

nit: same, maybe use 'less than a day' (because it will probably be used as part of a sentence and can be text transformed if needed)

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 80ee68f

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
indexLifecycleManagement	251.6KB	251.2KB	-431.0B

History

• 💚 Build #98908 succeeded 64878d3
• 💚 Build #98492 succeeded 316cc63
• 💚 Build #98173 succeeded a23654d
• 💚 Build #97879 succeeded ea8f0ee

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream