[7.11] [Uptime] Fix/details page tabs (#86296) #87796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove tabs from details page * update * fix monitord id * var name * add Uptime PageHeader tests to test for the presences of tabs or header * add Uptime MonitorPageTitle test * Uptime adjust auto generated monitor id regex * Uptime add tests for MonitorPageTitle to test behavior for missing monitor names and auto generated monitor ids * remove history from MonitorPageTitle test * adjust uptime tabs tests * adjust MonitorPageTitle tests to mock useSelector * adjust uptime PageHeader tests * adjust import order in page_header.test * add props to Uptime PageHeader to determine render, rather than route context * alphabetize props in Uptime PageHeader * remove header from individual pages * add indepdent page header route that matches all paths * adjust monitor tests to use mockReduxHooks helper, and add mockReactRouterDomHooks * update tests * adjust header spacing Co-authored-by: Shahzad <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.11: