-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Update reporting docs #87651
Merged
Merged
[Docs] Update reporting docs #87651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `kbn-version` reference to `kbn-xsrf` instead, which is what external consumers should be using.
jportner
added
chore
release_note:skip
Skip the PR/issue when compiling release notes
labels
Jan 7, 2021
@elasticmachine merge upstream |
tsullivan
approved these changes
Jan 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Jan 11, 2021
jportner
added a commit
to jportner/kibana
that referenced
this pull request
Jan 11, 2021
jportner
added a commit
to jportner/kibana
that referenced
this pull request
Jan 11, 2021
jportner
added a commit
to jportner/kibana
that referenced
this pull request
Jan 11, 2021
This was referenced Jan 11, 2021
jportner
added a commit
to jportner/kibana
that referenced
this pull request
Jan 11, 2021
jportner
added a commit
to jportner/kibana
that referenced
this pull request
Jan 11, 2021
# Conflicts: # docs/user/reporting/script-example.asciidoc
jportner
added a commit
to jportner/kibana
that referenced
this pull request
Jan 11, 2021
# Conflicts: # docs/user/reporting/script-example.asciidoc
jportner
added a commit
to jportner/kibana
that referenced
this pull request
Jan 11, 2021
# Conflicts: # docs/user/reporting/script-example.asciidoc
jportner
added a commit
to jportner/kibana
that referenced
this pull request
Jan 11, 2021
# Conflicts: # docs/user/reporting/script-example.asciidoc
jportner
added a commit
to jportner/kibana
that referenced
this pull request
Jan 11, 2021
# Conflicts: # docs/user/reporting/script-example.asciidoc
jportner
added a commit
to jportner/kibana
that referenced
this pull request
Jan 11, 2021
# Conflicts: # docs/user/reporting/script-example.asciidoc
jportner
added a commit
that referenced
this pull request
Jan 11, 2021
jportner
added a commit
that referenced
this pull request
Jan 11, 2021
jportner
added a commit
that referenced
this pull request
Jan 11, 2021
jportner
added a commit
that referenced
this pull request
Jan 11, 2021
jportner
added a commit
that referenced
this pull request
Jan 11, 2021
jportner
added a commit
that referenced
this pull request
Jan 11, 2021
jportner
added a commit
that referenced
this pull request
Jan 11, 2021
jportner
added a commit
that referenced
this pull request
Jan 11, 2021
jportner
added a commit
that referenced
this pull request
Jan 11, 2021
jportner
added a commit
that referenced
this pull request
Jan 11, 2021
jportner
added a commit
that referenced
this pull request
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Reporting docs instruct consumers to include the
kbn-version: x.y.z
header to satisfy our XSRF protection checks. However, external consumers should be using thekbn-xsrf: true
header instead.Docs preview: https://kibana_87651.docs-preview.app.elstc.co/diff
Note: we need to backport this change all the way back to 7.2, but the "Using the APIs" page didn't exist until 7.5. So the backports for 7.2, 7.3, and 7.4 will need to be tweaked to remove this sentence: