Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update reporting docs #87651

Merged
merged 2 commits into from
Jan 11, 2021
Merged

Conversation

jportner
Copy link
Contributor

@jportner jportner commented Jan 7, 2021

The Reporting docs instruct consumers to include the kbn-version: x.y.z header to satisfy our XSRF protection checks. However, external consumers should be using the kbn-xsrf: true header instead.

Docs preview: https://kibana_87651.docs-preview.app.elstc.co/diff

Note: we need to backport this change all the way back to 7.2, but the "Using the APIs" page didn't exist until 7.5. So the backports for 7.2, 7.3, and 7.4 will need to be tweaked to remove this sentence:

For more information, see API Request Headers.

Change `kbn-version` reference to `kbn-xsrf` instead, which is what
external consumers should be using.
@jportner jportner added chore release_note:skip Skip the PR/issue when compiling release notes labels Jan 7, 2021
@jportner
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jportner jportner merged commit 1927556 into elastic:master Jan 11, 2021
@jportner jportner deleted the update-reporting-docs branch January 11, 2021 19:53
jportner added a commit to jportner/kibana that referenced this pull request Jan 11, 2021
jportner added a commit to jportner/kibana that referenced this pull request Jan 11, 2021
jportner added a commit to jportner/kibana that referenced this pull request Jan 11, 2021
jportner added a commit to jportner/kibana that referenced this pull request Jan 11, 2021
jportner added a commit to jportner/kibana that referenced this pull request Jan 11, 2021
# Conflicts:
#	docs/user/reporting/script-example.asciidoc
jportner added a commit to jportner/kibana that referenced this pull request Jan 11, 2021
# Conflicts:
#	docs/user/reporting/script-example.asciidoc
jportner added a commit to jportner/kibana that referenced this pull request Jan 11, 2021
# Conflicts:
#	docs/user/reporting/script-example.asciidoc
jportner added a commit to jportner/kibana that referenced this pull request Jan 11, 2021
# Conflicts:
#	docs/user/reporting/script-example.asciidoc
jportner added a commit to jportner/kibana that referenced this pull request Jan 11, 2021
# Conflicts:
#	docs/user/reporting/script-example.asciidoc
jportner added a commit to jportner/kibana that referenced this pull request Jan 11, 2021
# Conflicts:
#	docs/user/reporting/script-example.asciidoc
jportner added a commit that referenced this pull request Jan 11, 2021
jportner added a commit that referenced this pull request Jan 11, 2021
jportner added a commit that referenced this pull request Jan 11, 2021
jportner added a commit that referenced this pull request Jan 11, 2021
jportner added a commit that referenced this pull request Jan 11, 2021
jportner added a commit that referenced this pull request Jan 11, 2021
jportner added a commit that referenced this pull request Jan 11, 2021
jportner added a commit that referenced this pull request Jan 11, 2021
jportner added a commit that referenced this pull request Jan 11, 2021
jportner added a commit that referenced this pull request Jan 11, 2021
jportner added a commit that referenced this pull request Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants