Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NA): move apm plugin tests out of __tests__ folder #87601

Merged
merged 2 commits into from
Jan 7, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Jan 7, 2021

It moves the second item of #85513 forward as it moves apm tests out of tests folder into our common setup for tests run with jest.

@mistic mistic requested review from a team as code owners January 7, 2021 01:33
@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Jan 7, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@mistic mistic added chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.11.1 v7.12.0 v8.0.0 and removed Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Jan 7, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic mistic requested a review from tylersmalley January 7, 2021 01:34
@mistic
Copy link
Member Author

mistic commented Jan 7, 2021

@elasticmachine merge upstream

@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Jan 7, 2021
@mistic mistic removed Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Jan 7, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've wanted to do something about this for a while. Thanks for making a decision for us!

@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Jan 7, 2021
@mistic mistic merged commit d681638 into elastic:master Jan 7, 2021
@mistic
Copy link
Member Author

mistic commented Jan 7, 2021

7.x/7.12: b2e6c2f
7.11/7.11.1: 29df95d

mistic added a commit to mistic/kibana that referenced this pull request Jan 7, 2021
mistic added a commit to mistic/kibana that referenced this pull request Jan 7, 2021
mistic added a commit that referenced this pull request Jan 7, 2021
mistic added a commit that referenced this pull request Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Operations Team label for Operations Team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.11.1 v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants