Internal server error when saving a widget with German characters in name #8758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now there are situations in which ElasticSearch puts characters in the character code range between 128 and 255 into the `Location` header. This leads to an exception when trying to pass on that header through the hapi proxy in versions before 15.0.0, because it validates that only US-ASCII characters are used in headers. To work around that situation, the `Location` header is encoded using `encodeURI()` for now. Closes elastic#8705
spalger
force-pushed
the
issue-8705-header-encoding
branch
from
89d8b93 to
fec5e1a
Compare
tylersmalley
approved these changes
Oct 19, 2016
jbudz
approved these changes
Oct 19, 2016
elastic-jasper
added a commit
that referenced
this pull request
Oct 19, 2016
--------- **Commit 1:** URI-encode forwarded location header in proxy Right now there are situations in which ElasticSearch puts characters in the character code range between 128 and 255 into the `Location` header. This leads to an exception when trying to pass on that header through the hapi proxy in versions before 15.0.0, because it validates that only US-ASCII characters are used in headers. To work around that situation, the `Location` header is encoded using `encodeURI()` for now. Closes #8705 * Original sha: 18c23c1 * Authored by Felix Stürmer <[email protected]> on 2016-10-18T17:55:31Z **Commit 2:** Add test to verify umlaut in vis name Relates to #8705 * Original sha: e100e1f * Authored by Felix Stürmer <[email protected]> on 2016-10-19T09:01:46Z **Commit 3:** [elasticsearch/proxy] use different code path with erorr * Original sha: fec5e1a * Authored by spalger <[email protected]> on 2016-10-19T19:06:39Z
elastic-jasper
added a commit
that referenced
this pull request
Oct 19, 2016
--------- **Commit 1:** URI-encode forwarded location header in proxy Right now there are situations in which ElasticSearch puts characters in the character code range between 128 and 255 into the `Location` header. This leads to an exception when trying to pass on that header through the hapi proxy in versions before 15.0.0, because it validates that only US-ASCII characters are used in headers. To work around that situation, the `Location` header is encoded using `encodeURI()` for now. Closes #8705 * Original sha: 18c23c1 * Authored by Felix Stürmer <[email protected]> on 2016-10-18T17:55:31Z **Commit 2:** Add test to verify umlaut in vis name Relates to #8705 * Original sha: e100e1f * Authored by Felix Stürmer <[email protected]> on 2016-10-19T09:01:46Z **Commit 3:** [elasticsearch/proxy] use different code path with erorr * Original sha: fec5e1a * Authored by spalger <[email protected]> on 2016-10-19T19:06:39Z
spalger
added a commit
that referenced
this pull request
Oct 19, 2016
[backport] PR #8758 to 5.0 - Internal server error when saving a widget with German characters in name
spalger
added a commit
that referenced
this pull request
Oct 19, 2016
[backport] PR #8758 to 5.x - Internal server error when saving a widget with German characters in name
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
--------- **Commit 1:** URI-encode forwarded location header in proxy Right now there are situations in which ElasticSearch puts characters in the character code range between 128 and 255 into the `Location` header. This leads to an exception when trying to pass on that header through the hapi proxy in versions before 15.0.0, because it validates that only US-ASCII characters are used in headers. To work around that situation, the `Location` header is encoded using `encodeURI()` for now. Closes elastic#8705 * Original sha: 03ccb8ec56eb92c86162e307a286305384ba92c3 [formerly 18c23c1] * Authored by Felix Stürmer <[email protected]> on 2016-10-18T17:55:31Z **Commit 2:** Add test to verify umlaut in vis name Relates to elastic#8705 * Original sha: 238f6f64a55d113f30fd8f61f5330c1c97f23627 [formerly e100e1f] * Authored by Felix Stürmer <[email protected]> on 2016-10-19T09:01:46Z **Commit 3:** [elasticsearch/proxy] use different code path with erorr * Original sha: 0f7e4548c7808d845bf0df661d9a3742b81f14da [formerly fec5e1a] * Authored by spalger <[email protected]> on 2016-10-19T19:06:39Z Former-commit-id: afbc790
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[backport] PR elastic#8758 to 5.x - Internal server error when saving a widget with German characters in name Former-commit-id: 2c0a221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #8705
Closes #8705