chore(NA): move monitoring out of __tests__ folder #87556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistic
added
chore
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
tylersmalley
reviewed
Jan 6, 2021
x-pack/plugins/monitoring/server/cluster_alerts/alerts_clusters_aggregation.test.js
Show resolved
Hide resolved
tylersmalley
reviewed
Jan 6, 2021
x-pack/plugins/monitoring/server/cluster_alerts/verify_monitoring_license.test.js
Show resolved
Hide resolved
|
I am concerned with the tests which have been disabled. I am not familiar with any mocha tests which were not previously running. Do you have any more details to this? |
|
@tylersmalley as far as I could check our patterns to run I found a lot of tests that were just forgot somewhere and not being run at all. When I've tried to migrate them into jest they failed because they were already pretty outdated. I've decided to make the ones passing to run again and add those notes to the one not running and let the underlying teams follow up on them. |
|
I see, appears to be test files under |
tylersmalley
approved these changes
Jan 6, 2021
igoristic
approved these changes
Jan 7, 2021
There was a problem hiding this comment.
Looks good from Stack Monitoring side. Thank you for this 👍
@tylersmalley I created the issue to track the two failing tests: #87620
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
|
7.x/7.12: dd71d8f |
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Jan 7, 2021
* chore(NA): move server and common from monitoring out of the __tests__ folder * chore(NA): move monitoring public out of __tests__ folder * chore(NA): add missing skip on test Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/plugins/monitoring/server/kibana_monitoring/collectors/get_default_admin_email.test.js
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Jan 7, 2021
* chore(NA): move server and common from monitoring out of the __tests__ folder * chore(NA): move monitoring public out of __tests__ folder * chore(NA): add missing skip on test Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/plugins/monitoring/server/kibana_monitoring/collectors/get_default_admin_email.test.js
mistic
added a commit
that referenced
this pull request
Jan 7, 2021
…7689) * chore(NA): move monitoring out of __tests__ folder (#87556) * chore(NA): move server and common from monitoring out of the __tests__ folder * chore(NA): move monitoring public out of __tests__ folder * chore(NA): add missing skip on test Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/plugins/monitoring/server/kibana_monitoring/collectors/get_default_admin_email.test.js * test(NA): fix tests * chore(NA): fix some tests
mistic
added a commit
that referenced
this pull request
Jan 7, 2021
…87690) * chore(NA): move monitoring out of __tests__ folder (#87556) * chore(NA): move server and common from monitoring out of the __tests__ folder * chore(NA): move monitoring public out of __tests__ folder * chore(NA): add missing skip on test Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/plugins/monitoring/server/kibana_monitoring/collectors/get_default_admin_email.test.js * test(NA): fix tests * chore(NA): fix some tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It moves the second item of #85513 forward as it moves monitoring tests out of tests folder into our common setup for tests run with jest.