-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev/build] skip reporting unreliable metrics #87531
[dev/build] skip reporting unreliable metrics #87531
Conversation
Pinging @elastic/kibana-operations (Team:Operations) |
Do you know why these values aren't accurate? Should we continue reporting them and remove them from the comment? |
I don't know, but I know that both the size and file count fluctuate even for the same commit. I suspect it's the node_modules or something but I plan to investigate them in a follow up PR so I'd like to have them in the comment for that PR rather than disable the metric server-side. |
I have also seen similar fluctuations going back at least a month, so I don't think there's an urgent need to remove these metrics from PRs, another reason we probably don't need to disable them server-side |
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Distributable file count
History
To update your PR or re-run it, just comment with: |
* [dev/build] skip reporting unreliable metrics * remove unused import Co-authored-by: spalger <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
* [dev/build] skip reporting unreliable metrics * remove unused import Co-authored-by: spalger <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
* [dev/build] skip reporting unreliable metrics * remove unused import Co-authored-by: spalger <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: spalger <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
* [dev/build] skip reporting unreliable metrics * remove unused import Co-authored-by: spalger <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: spalger <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
RE #87529
The metrics for the distributable file count and size are inaccurate enough that most PRs show a change in these values even when they shouldn't, and when they should the change in size can't be trusted.