Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev/build] skip reporting unreliable metrics #87531

Merged
merged 3 commits into from
Jan 6, 2021

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jan 6, 2021

RE #87529

The metrics for the distributable file count and size are inaccurate enough that most PRs show a change in these values even when they shouldn't, and when they should the change in size can't be trusted.

@spalger spalger added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v7.12.0 labels Jan 6, 2021
@spalger spalger requested a review from a team as a code owner January 6, 2021 17:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@tylersmalley
Copy link
Contributor

Do you know why these values aren't accurate? Should we continue reporting them and remove them from the comment?

@spalger
Copy link
Contributor Author

spalger commented Jan 6, 2021

I don't know, but I know that both the size and file count fluctuate even for the same commit. I suspect it's the node_modules or something but I plan to investigate them in a follow up PR so I'd like to have them in the comment for that PR rather than disable the metric server-side.

@spalger
Copy link
Contributor Author

spalger commented Jan 6, 2021

I have also seen similar fluctuations going back at least a month, so I don't think there's an urgent need to remove these metrics from PRs, another reason we probably don't need to disable them server-side

@spalger
Copy link
Contributor Author

spalger commented Jan 6, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 48020 - -48020
oss 27710 - -27710

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit ab944b4 into elastic:master Jan 6, 2021
spalger added a commit to spalger/kibana that referenced this pull request Jan 6, 2021
* [dev/build] skip reporting unreliable metrics

* remove unused import

Co-authored-by: spalger <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
spalger added a commit to spalger/kibana that referenced this pull request Jan 6, 2021
* [dev/build] skip reporting unreliable metrics

* remove unused import

Co-authored-by: spalger <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
spalger added a commit that referenced this pull request Jan 7, 2021
* [dev/build] skip reporting unreliable metrics

* remove unused import

Co-authored-by: spalger <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: spalger <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
spalger added a commit that referenced this pull request Jan 7, 2021
* [dev/build] skip reporting unreliable metrics

* remove unused import

Co-authored-by: spalger <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: spalger <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
@spalger spalger deleted the fix/distributable-file-count-floppy branch January 7, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.11.0 v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants