Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add content for the new Service Overview page #87496

Merged
merged 3 commits into from
Jan 12, 2021

Conversation

EamonnTP
Copy link

@EamonnTP EamonnTP commented Jan 6, 2021

Summary

This PR adds content for the new Service Overview page for 7.11.

HTML preview

https://kibana_87496.docs-preview.app.elstc.co/guide/en/kibana/master/service-overview.html

Related issue

Closes #82055

@EamonnTP EamonnTP added Team:APM All issues that need APM UI Team support release_note:skip Skip the PR/issue when compiling release notes v7.11.1 labels Jan 6, 2021
@EamonnTP EamonnTP requested review from bmorelli25 and a team January 6, 2021 14:42
@EamonnTP EamonnTP self-assigned this Jan 6, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@EamonnTP
Copy link
Author

EamonnTP commented Jan 6, 2021

@elasticmachine, run elasticsearch-ci/docs rebuild

=== Error rate and errors

The *Error rate* chart displays the average error rates relating to the service, within a specific time range.
Copy link
Member

@sorenlouv sorenlouv Jan 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine but just want to clarify that "Error rate" is (somewhat confusingly) based on transaction instead of error documents.
To be exact it is based on the event.outcome field and is the relative number of failed transactions.

We might want to let users in on this secret - or maybe not. Depends on how much detail we can give them without confusing them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like I've seen this come up in discuss in the past. I think it makes sense to keep it high-level here, but maybe update the Error rate info on this page with the secret sauce.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmorelli25 Thanks, will do. I included the other update in this PR.

Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

which spans could be slowing down transactions. The "app" label displayed under the
chart indicates that something was happening within the application. This could signal that the
agent does not have auto-instrumentation for whatever was happening during that time or the time was spent in the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add that?

Suggested change
agent does not have auto-instrumentation for whatever was happening during that time or the time was spent in the
agent does not have auto-instrumentation for whatever was happening during that time or that the time was spent in the

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Thanks!

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small suggestions, otherwise LGTM.

Comment on lines 5 to 7
visibility into how a service performs across your infrastructure. To help you isolate
potential issues, select a <<services,*service*>> to bring you to the *Service overview* page.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The working feels a bit strange as-is. What about this?

Suggested change
The *Service overview* page contains a wide variety of charts and tables that provide
visibility into how a service performs across your infrastructure. To help you isolate
potential issues, select a <<services,*service*>> to bring you to the *Service overview* page.
Selecting a <<services,*service*>> brings you to the *Service overview*.
The *Service overview* contains a wide variety of charts and tables that provide
visibility into how a service performs across your infrastructure.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@EamonnTP EamonnTP merged commit 4afaa2d into elastic:master Jan 12, 2021
@EamonnTP EamonnTP deleted the service-overview branch January 12, 2021 16:53
EamonnTP pushed a commit to EamonnTP/kibana that referenced this pull request Jan 12, 2021
* Add service overview content

* Edits following reviews

* Review edits
EamonnTP pushed a commit that referenced this pull request Jan 12, 2021
* Add service overview content

* Edits following reviews

* Review edits
EamonnTP pushed a commit that referenced this pull request Jan 12, 2021
* Add service overview content

* Edits following reviews

* Review edits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.11.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] docs: Update documentation to reflect new Service Overview
5 participants