-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(NA): move uptime plugin tests out of __tests__ folder #87416
Conversation
Pinging @elastic/kibana-operations (Team:Operations) |
Pinging @elastic/uptime (Team:uptime) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor thing.
.../uptime/public/components/monitor/status_details/location_map/embeddables/map_config.test.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build SucceededMetrics [docs]Distributable file count
History
To update your PR or re-run it, just comment with: |
…87416) * chore(NA): move uptime plugin tests out of __tests__ folder * chore(NA): re-add file into __mocks__ folder
…87416) * chore(NA): move uptime plugin tests out of __tests__ folder * chore(NA): re-add file into __mocks__ folder # Conflicts: # x-pack/plugins/uptime/server/lib/alerts/status_check.test.ts
It moves the second item of #85513 forward as it moves uptime tests out of tests folder into our common setup for tests run with jest.