Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NA): move uptime plugin tests out of __tests__ folder #87416

Merged
merged 3 commits into from
Jan 6, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Jan 6, 2021

It moves the second item of #85513 forward as it moves uptime tests out of tests folder into our common setup for tests run with jest.

@mistic mistic added chore Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v7.11.1 labels Jan 6, 2021
@mistic mistic requested a review from tylersmalley January 6, 2021 00:35
@mistic mistic requested a review from a team as a code owner January 6, 2021 00:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jan 6, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor thing.

Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 47254 48020 +766

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit 9a0c331 into elastic:master Jan 6, 2021
mistic added a commit to mistic/kibana that referenced this pull request Jan 6, 2021
…87416)

* chore(NA): move uptime plugin tests out of __tests__ folder

* chore(NA): re-add file into __mocks__ folder
mistic added a commit to mistic/kibana that referenced this pull request Jan 6, 2021
…87416)

* chore(NA): move uptime plugin tests out of __tests__ folder

* chore(NA): re-add file into __mocks__ folder
# Conflicts:
#	x-pack/plugins/uptime/server/lib/alerts/status_check.test.ts
@mistic
Copy link
Member Author

mistic commented Jan 6, 2021

7.x/7.12: b18776f
7.11/7.11.1: a5126f7

mistic added a commit that referenced this pull request Jan 6, 2021
…87557)

* chore(NA): move uptime plugin tests out of __tests__ folder

* chore(NA): re-add file into __mocks__ folder
mistic added a commit that referenced this pull request Jan 6, 2021
…87416) (#87558)

* chore(NA): move uptime plugin tests out of __tests__ folder (#87416)

* chore(NA): move uptime plugin tests out of __tests__ folder

* chore(NA): re-add file into __mocks__ folder
# Conflicts:
#	x-pack/plugins/uptime/server/lib/alerts/status_check.test.ts

* chore(NA): fix eslint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.11.1 v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants