Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.11] [SecuritySolution][Detections] Fix "Closing a signal silently fails with reduced privileges" (#86908) #87414

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

yctercero
Copy link
Contributor

Backports the following commits to 7.11:

…ith reduced privileges" (elastic#86908)

## Summary

This PR introduces the following changes. If the user has insufficient write privileges on the signals index:

- we disable the status-changing actions on detection alerts ("Open alert", "Close Alert", "Mark in progress") in the context menu of an alert in alerts table
- we make sure to show the corresponding callout that tells about read-only access to detection alerts
- in the callout we provide links to docs for understanding why/how to fix
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

"before all" hook for "sets the KQL from a single IP with a value for the query".ml conditional links "before all" hook for "sets the KQL from a single IP with a value for the query"

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has failed 4 times on tracked branches: https://github.com/elastic/kibana/issues/86979

Error: Timed out while retrying, last result was: {false}

Because this error occurred during a `before all` hook we are skipping the remaining tests in the current suite: `ml conditional links`

Although you have test retries enabled, we do not retry tests when `before all` or `after all` hooks fail
    at Context.completeOrRetry (http://localhost:61131/__cypress/tests?p=cypress/support/index.js:1414:13)

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2166 2171 +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.5MB 8.5MB +4.4KB
triggersActionsUi 1.5MB 1.5MB -26.9KB
total -22.5KB

Distributable file count

id before after diff
default 47634 48397 +763

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 162.0KB 162.1KB +102.0B
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 31 32 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yctercero yctercero merged commit a8e6979 into elastic:7.11 Jan 6, 2021
@yctercero yctercero deleted the backport/7.11/pr-86908 branch October 13, 2021 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants