-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Use documentation link service in more ML pages #87389
Conversation
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested changes here and LGTM. Added a question about the format of the help link text.
Also, I did a quick search on where we use .html
in the code, and the only other hard-coded links I found were in ml/common/constants/messages.ts
which are for the job validation links:
Not sure if you wanted to include those too?
href={`${ELASTIC_WEBSITE_URL}guide/en/elasticsearch/reference/${DOC_LINK_VERSION}/indices-create-index.html#indices-create-index`} | ||
target="_blank" | ||
> | ||
<EuiLink href={createIndexLink} target="_blank"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an example of "Learn more" with an ending period in https://elastic.github.io/eui/#/guidelines/writing and a quick chat with @gchaps indicates it's preferred in general. I will open a separate PR to get consistency on that.
@elasticmachine merge upstream |
Thanks! I've started investigating fixes for those links in #87763 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Summary
Replaces more hard-coded documentation links in the machine learning app with keywords from the documentation link service