Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] Add a helper for clearFlashMessages #87383

Conversation

scottybollinger
Copy link
Contributor

@scottybollinger scottybollinger commented Jan 5, 2021

This PR adds a convenience function for clearing flash messages to align with others.

Summary

In Workplace Search there were several places where we were only importing FlashMessagesLogic to call this method and it would be cleaner to have this helper along with the others.

Checklist

This PR adds a convenience function for clearing flash messages to align with others.
@scottybollinger scottybollinger added Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Jan 5, 2021
@scottybollinger scottybollinger requested a review from a team January 5, 2021 20:43
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.8MB 1.8MB +158.0B

Distributable file count

id before after diff
default 47253 48013 +760

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@scottybollinger scottybollinger merged commit 3e3a809 into elastic:master Jan 5, 2021
@scottybollinger scottybollinger deleted the scottybollinger/clear-fm-helper branch January 5, 2021 22:54
scottybollinger added a commit to scottybollinger/kibana that referenced this pull request Jan 5, 2021
This PR adds a convenience function for clearing flash messages to align with others.
scottybollinger added a commit that referenced this pull request Jan 6, 2021
)

This PR adds a convenience function for clearing flash messages to align with others.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v7.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants