Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Do not display inactive enrollment token in the agent enrollment flyout #87300

Merged

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Jan 5, 2021

Description

Resolve #87287

We should not display inactive Enrollment token to the user in the add agent flyout. This PR fix that bug

With the following tokens

Screen Shot 2021-01-05 at 9 19 36 AM

Before

Screen Shot 2021-01-05 at 9 20 18 AM

After

Screen Shot 2021-01-05 at 9 19 43 AM

How to test

  • Create a new enrollment token
  • Delete it (desactivate it)
  • then try to add an agent, you should not see the token

@nchaulet nchaulet added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 v7.12.0 labels Jan 5, 2021
@nchaulet nchaulet requested a review from jen-huang January 5, 2021 13:37
@nchaulet nchaulet self-assigned this Jan 5, 2021
@nchaulet nchaulet requested a review from a team January 5, 2021 13:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 967.8KB 967.9KB +19.0B

Distributable file count

id before after diff
default 47252 48012 +760

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also closes #73529 😄

LGTM!

@dikshachauhan-qasource
Copy link

Hi @nchaulet

Today, we performing testing around enrollment token keys on 7.11 BC2 Kibana cloud build. Build details are as follows:

BUILD 37605
COMMIT a5126f7a280a6f4a27dc3aca65c1c89ccd1ac694

We have observed that when a token is deleted for active policy and no new token is generated for that policy, then enrollment token field is populated with default policy's token that was available in active state in agent enrollment flyout. Also, we were successfully able to install agent used that updated command.

However, no validation message such as 'no active keys available for this policy' was shown to agent on selecting policy with no active enrollment token on agent enrollment flyout.

Though, enrollment field was displayed blank under Authentication settings on agent enrollment flyout.

Please let us know if anything is required from our side.

Screenshot:
#87300_observation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 v7.12.0 v8.0.0
Projects
None yet
5 participants