-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Do not display inactive enrollment token in the agent enrollment flyout #87300
[Fleet] Do not display inactive enrollment token in the agent enrollment flyout #87300
Conversation
Pinging @elastic/ingest-management (Team:Ingest Management) |
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also closes #73529 😄
LGTM!
Hi @nchaulet Today, we performing testing around enrollment token keys on 7.11 BC2 Kibana cloud build. Build details are as follows:
We have observed that when a token is deleted for active policy and no new token is generated for that policy, then enrollment token field is populated with default policy's token that was available in active state in agent enrollment flyout. Also, we were successfully able to install agent used that updated command. However, no validation message such as 'no active keys available for this policy' was shown to agent on selecting policy with no active enrollment token on agent enrollment flyout. Though, enrollment field was displayed blank under Authentication settings on agent enrollment flyout. Please let us know if anything is required from our side. |
Description
Resolve #87287
We should not display inactive Enrollment token to the user in the add agent flyout. This PR fix that bug
With the following tokens
Before
After
How to test