Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] only render ping status code badge when status code is available #87096

Merged
merged 5 commits into from
Jan 5, 2021
Merged

[Uptime] only render ping status code badge when status code is available #87096

merged 5 commits into from
Jan 5, 2021

Conversation

dominiqueclarke
Copy link
Contributor

@dominiqueclarke dominiqueclarke commented Dec 31, 2020 •
edited
Loading

Summary

Fixes #79192

Prevents status column badges for displaying without content.

Before
image

After
Screen Shot 2021-01-04 at 3 01 19 PM

Checklist

Delete any items that are not applicable to this PR.

@dominiqueclarke dominiqueclarke added bug Fixes for quality problems that affect the customer experience v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.11.0 labels Dec 31, 2020
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner December 31, 2020 18:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@dominiqueclarke dominiqueclarke added the release_note:skip Skip the PR/issue when compiling release notes label Dec 31, 2020
@dominiqueclarke
Copy link
Contributor Author

@elasticmachine merge upstream

shahzad31
shahzad31 approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one optional suggestion is to use - instead of empty column.

like error type column.

@dominiqueclarke
Copy link
Contributor Author

LGTM, one optional suggestion is to use - instead of empty column.

like error type column.

Is that able to be done on a per row basis? In this issue, it appeared as if there were a mix of successful and failed rows in the same column.

@dominiqueclarke
Copy link
Contributor Author

dominiqueclarke commented Jan 4, 2021 •
edited
Loading

LGTM, one optional suggestion is to use - instead of empty column.

like error type column.

I misunderstood you at first, but now I think I understand. You mean with the badge container, or without?
Screen Shot 2021-01-04 at 2 58 35 PM
Screen Shot 2021-01-04 at 3 01 19 PM

@shahzad31
Copy link
Contributor

LGTM, one optional suggestion is to use - instead of empty column.
like error type column.

I misunderstood you at first, but now I think I understand. You mean with the badge container, or without?
Screen Shot 2021-01-04 at 2 58 35 PM
Screen Shot 2021-01-04 at 3 01 19 PM

@dominiqueclarke i think without badge container.

@dominiqueclarke
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 1.0MB 1.0MB +49.0B

Distributable file count

id before after diff
default 47252 48012 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dominiqueclarke dominiqueclarke merged commit 16ad4d6 into elastic:master Jan 5, 2021
@dominiqueclarke dominiqueclarke deleted the fix/79192-uptime-remove-empty-status-code-badges branch January 5, 2021 17:46
@dominiqueclarke dominiqueclarke mentioned this pull request Jan 5, 2021
Merged
dominiqueclarke added a commit to dominiqueclarke/kibana that referenced this pull request Jan 5, 2021
@dominiqueclarke @kibanamachine
[Uptime] only render ping status code badge when status code is avail…
e85a9d1 
…able (elastic#87096)

* uptime only render ping status code badge when status code is available

* uptime update ResponseCodeColumn error state

Co-authored-by: Kibana Machine <[email protected]>
@dominiqueclarke dominiqueclarke mentioned this pull request Jan 5, 2021
Merged
dominiqueclarke added a commit to dominiqueclarke/kibana that referenced this pull request Jan 5, 2021
@dominiqueclarke @kibanamachine
[Uptime] only render ping status code badge when status code is avail…
2af39c1 
…able (elastic#87096)

* uptime only render ping status code badge when status code is available

* uptime update ResponseCodeColumn error state

Co-authored-by: Kibana Machine <[email protected]>
dominiqueclarke added a commit that referenced this pull request Jan 5, 2021
@dominiqueclarke @kibanamachine
[Uptime] only render ping status code badge when status code is avail…
d383e51 
…able (#87096) (#87359)

* uptime only render ping status code badge when status code is available

* uptime update ResponseCodeColumn error state

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
dominiqueclarke added a commit that referenced this pull request Jan 5, 2021
@dominiqueclarke @kibanamachine
[Uptime] only render ping status code badge when status code is avail…
f1a1bb9 
…able (#87096) (#87360)

* uptime only render ping status code badge when status code is available

* uptime update ResponseCodeColumn error state

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Uptime] Empty badge displayed for response code on detail page
4 participants
@dominiqueclarke @elasticmachine @shahzad31 @kibanamachine