Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics UI] Disable recovery action scheduling #87061

Merged
merged 4 commits into from
Jan 6, 2021

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Dec 30, 2020

Summary

Closes #87057

The alerting framework doesn't yet support recovery alert messages the way we implemented them. This PR disables them for the time being until that's resolved.

Checklist

@Zacqary Zacqary added Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v7.12.0 labels Dec 30, 2020
@Zacqary Zacqary requested a review from a team as a code owner December 30, 2020 17:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@Zacqary
Copy link
Contributor Author

Zacqary commented Dec 30, 2020

@elasticmachine merge upstream

@Zacqary
Copy link
Contributor Author

Zacqary commented Jan 4, 2021

@elasticmachine merge upstream

Copy link
Contributor

@phillipb phillipb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zacqary
Copy link
Contributor Author

Zacqary commented Jan 6, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 47256 48019 +763

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Zacqary Zacqary merged commit 6df7498 into elastic:master Jan 6, 2021
@Zacqary Zacqary deleted the 87057-recovery-disable branch January 6, 2021 21:45
Zacqary added a commit to Zacqary/kibana that referenced this pull request Jan 6, 2021
Zacqary added a commit to Zacqary/kibana that referenced this pull request Jan 6, 2021
Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	x-pack/plugins/infra/server/lib/alerting/metric_threshold/metric_threshold_executor.test.ts
Zacqary added a commit that referenced this pull request Jan 7, 2021
Zacqary added a commit that referenced this pull request Jan 7, 2021
Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	x-pack/plugins/infra/server/lib/alerting/metric_threshold/metric_threshold_executor.test.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Metrics UI Metrics UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.11.0 v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metrics UI] Disable recovery action scheduling in threshold/inventory alerts
4 participants