Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Actions] Gracefully handling unknown action type #86910

Merged
merged 3 commits into from
Jan 5, 2021
Merged

[Actions] Gracefully handling unknown action type #86910

merged 3 commits into from
Jan 5, 2021

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Dec 23, 2020

Resolves #66722

Summary

To reproduce:

  1. Create a connector
  2. Comment out registration of the connectort type you just created (in x-pack/plugins/actions/server/builtin_action_types/index.ts and restart Kibana)
  3. Connector list page should still load and the connector you created in (1) should show up as disabled, except for the Delete button, which should still allow you to delete the connector.

In the below screenshot, I created an Index Connector and the commented the out the registration for getIndexActionType
Screen Shot 2020-12-23 at 1 47 10 PM

Checklist

@ymao1 ymao1 self-assigned this Dec 23, 2020
@ymao1 ymao1 added Feature:Actions release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.12.0 v8.0.0 labels Dec 23, 2020
@ymao1 ymao1 marked this pull request as ready for review December 23, 2020 18:52
@ymao1 ymao1 requested a review from a team as a code owner December 23, 2020 18:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

YulNaumenko
YulNaumenko approved these changes Dec 23, 2020
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymao1
Copy link
Contributor Author

ymao1 commented Jan 4, 2021

@elasticmachine merge upstream

mikecote
mikecote approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ymao1
Copy link
Contributor Author

ymao1 commented Jan 5, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.6MB 1.6MB +435.0B

Distributable file count

id before after diff
default 47252 48012 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ymao1 ymao1 merged commit eabd708 into elastic:master Jan 5, 2021
ymao1 added a commit to ymao1/kibana that referenced this pull request Jan 5, 2021
@ymao1 @kibanamachine
Disabling connectors for invalid connector types (elastic#86910)
3c75b8d 
Co-authored-by: Kibana Machine <[email protected]>
@ymao1 ymao1 mentioned this pull request Jan 5, 2021
Merged
ymao1 added a commit that referenced this pull request Jan 5, 2021
@ymao1 @kibanamachine
Disabling connectors for invalid connector types (#86910) (#87355)
1ad8b59 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
@mikecote mikecote added release_note:fix and removed release_note:skip Skip the PR/issue when compiling release notes labels Feb 2, 2021
@ymao1 ymao1 deleted the alerting/unknown-connector branch February 4, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecote mikecote mikecote approved these changes

@YulNaumenko YulNaumenko YulNaumenko approved these changes

Assignees

@ymao1 ymao1

Labels
Feature:Actions release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Alerting] unexpected action type causes null dereference
5 participants
@ymao1 @elasticmachine @kibanamachine @mikecote @YulNaumenko