switched out underscore with lodash #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Jan 25, 2014
Create the store by passing in a scope, name, and default value. The current value is are fetched from localStorage, and changes to the object are synched with localStorage. The value is JSON stringified, so only store primative/simple values and the value must be an object. Includes changes from elastic#869
Merged
|
Have you tested out anything that uses the mixins? There isnt much and I don't see any reason for them to fail, I just want to be sure here. |
|
Not really, no. Will do |
Merged
spalger
pushed a commit
that referenced
this pull request
Jan 27, 2014
switched out underscore with lodash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lodash offers several additional function and many performance enhancements