Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small multiples in vis_type_xy plugin #86880

Merged
merged 30 commits into from
Jan 25, 2021
Merged
Changes from 2 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
f6b51c5
Small multiples in vis_type_xy plugin
DianaDerevyankina Dec 22, 2020
645933f
Fix tooltip and formatted split chart values
nickofthyme Dec 23, 2020
f9ddb84
update advanced settings wording
nickofthyme Dec 23, 2020
353b3ae
Merge branch 'master' into Diana/82496
DianaDerevyankina Dec 23, 2020
8f600af
Remove React import in files with no JSX and change the extension to .ts
DianaDerevyankina Dec 23, 2020
a967804
Merge branch 'master' into Diana/82496
kibanamachine Jan 7, 2021
0afd9d5
Merge branch 'master' into Diana/82496
DianaDerevyankina Jan 13, 2021
7ba9cea
Simplify conditions
DianaDerevyankina Jan 13, 2021
a7287b9
fix bar interval on split charts in vislib
nickofthyme Jan 13, 2021
842034b
Merge branch 'master' into Diana/82496
DianaDerevyankina Jan 14, 2021
ad44d9f
Fix charts not splitting for terms boolean fields
DianaDerevyankina Jan 14, 2021
30d0055
Merge pull request #1 from nickofthyme/nick-sm-fixes
DianaDerevyankina Jan 14, 2021
e51c5b0
fix filtering for small multiples
nickofthyme Jan 14, 2021
fceee26
Merge pull request #2 from nickofthyme/fix-filtering
DianaDerevyankina Jan 15, 2021
b6ab151
Merge branch 'master' into Diana/82496
kibanamachine Jan 15, 2021
870a728
Merge branch 'master' into Diana/82496
DianaDerevyankina Jan 18, 2021
92f9d1b
Change tests interval values from 100 to 1000000
DianaDerevyankina Jan 18, 2021
dc181eb
Merge branch 'master' into Diana/82496
DianaDerevyankina Jan 19, 2021
4ab6368
Revert "Change tests interval values from 100 to 1000000"
DianaDerevyankina Jan 19, 2021
9152287
Fix tests for interval issue in vislib
DianaDerevyankina Jan 16, 2021
e752837
Merge branch 'master' into Diana/82496
DianaDerevyankina Jan 20, 2021
ba53abd
Revert axis_scale changes related to interval
DianaDerevyankina Jan 20, 2021
282b571
Merge branch 'master' into Diana/82496
kibanamachine Jan 20, 2021
e2f602f
Merge branch 'master' into Diana/82496
kibanamachine Jan 21, 2021
cad1e20
Merge branch 'master' into Diana/82496
DianaDerevyankina Jan 22, 2021
965824b
Enable _line_chart_split_chart test for new charts library
DianaDerevyankina Jan 22, 2021
91d5df6
Merge branch 'master' into Diana/82496
kibanamachine Jan 25, 2021
4cf3bc9
Merge branch 'master' into Diana/82496
kibanamachine Jan 25, 2021
48780a0
Merge branch 'master' into Diana/82496
DianaDerevyankina Jan 25, 2021
4436b62
Move chart splitter id to const
DianaDerevyankina Jan 25, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/plugins/vis_type_xy/public/config/get_aspects.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,8 @@ export function getAspects(
y: getAspectsFromDimension(columns, y) ?? [],
z: z && z?.length > 0 ? getAspectsFromDimension(columns, z[0]) : undefined,
series: getAspectsFromDimension(columns, seriesDimensions),
splitColumn:
splitColumn && splitColumn?.length > 0
? getAspectsFromDimension(columns, splitColumn[0])
: undefined,
splitRow:
splitRow && splitRow?.length > 0 ? getAspectsFromDimension(columns, splitRow[0]) : undefined,
splitColumn: splitColumn?.length ? getAspectsFromDimension(columns, splitColumn[0]) : undefined,
splitRow: splitRow?.length ? getAspectsFromDimension(columns, splitRow[0]) : undefined,
};
}

Expand Down