[Alerting] Saved object remover for all e2e triggers_actions_ui tests #86837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing-saved-object-remover
ymao1
added
Feature:Alerting
release_note:skip
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
YulNaumenko
approved these changes
Dec 23, 2020
1 task
|
If #86838 is merged first, the functional test added in that PR will need to be updated. |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Distributable file count
History
To update your PR or re-run it, just comment with: |
ymao1
added a commit
to ymao1/kibana
that referenced
this pull request
Jan 4, 2021
…elastic#86837) * wip * Using object remover for alerts list * wip - using supertest instead of axios * wip - using supertest instead of axios * Removing custom services in favor of supertest * Fixing test * Fixing test * Fixing types check Co-authored-by: Kibana Machine <[email protected]>
ymao1
added a commit
that referenced
this pull request
Jan 4, 2021
…#86837) (#87158) * wip * Using object remover for alerts list * wip - using supertest instead of axios * wip - using supertest instead of axios * Removing custom services in favor of supertest * Fixing test * Fixing test * Fixing types check Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #79779
Summary
Added object remover to functional tests inside
x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui. Also switched to using commonsupertestservice for API calls to create alerts and actions instead of custom service.