Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Consistent display of agent counts on lists #86827

Merged
merged 4 commits into from
Dec 23, 2020
Merged

[Fleet] Consistent display of agent counts on lists #86827

merged 4 commits into from
Dec 23, 2020

Conversation

paul-tavares
Copy link
Contributor

@paul-tavares paul-tavares commented Dec 22, 2020 •
edited
Loading

Summary

Adjusts the display of Agent counts on lists to:

  • display as plain text if count is zero
  • display as a link to the Agents list (filtered by the given Agent policy) if count is greater than zero
  • display count as only a number

Policies List:
image

Integration Details Polices List:

image

Fixes #86373

Checklist

@paul-tavares paul-tavares added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.12.0 Team:Defend Workflows “EDR Workflows” sub-team of Security Solution labels Dec 22, 2020
@paul-tavares paul-tavares self-assigned this Dec 22, 2020
@paul-tavares paul-tavares requested a review from a team December 22, 2020 19:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

jfsiii
jfsiii approved these changes Dec 23, 2020
View reviewed changes
x-pack/plugins/fleet/public/applications/fleet/components/linked_agent_count.tsx
<EuiLink
{...otherEuiLinkProps}
href={getHref('fleet_agent_list', {
kuery: `${AGENT_SAVED_OBJECT_TYPE}.policy_id : ${agentPolicyId}`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this is different from the previous kuery below, but it seems to still work so 👍

kuery: `${AGENT_SAVED_OBJECT_TYPE}.policy_id:%20${agentPolicyId}`

@paul-tavares paul-tavares merged commit 0f838bf into elastic:master Dec 23, 2020
@paul-tavares paul-tavares deleted the task/fleet-86373-agent-count-display branch December 23, 2020 14:41
@paul-tavares paul-tavares mentioned this pull request Dec 23, 2020
Merged
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 963.8KB 964.6KB +736.0B

Distributable file count

id before after diff
default 47143 47903 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

paul-tavares added a commit that referenced this pull request Dec 23, 2020
@paul-tavares
[Fleet] Consistent display of agent counts on lists (#86827) (#86895)
df53ea7 
* move LinkedAgentCount component to top-level components and adjust output
* refactor integration details Policies list to use LinkedAgentCount component
* test cases for agent counts on integrations
@Zacqary Zacqary mentioned this pull request May 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinlog kevinlog kevinlog approved these changes

@jfsiii jfsiii jfsiii approved these changes

Assignees

@paul-tavares paul-tavares

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team:Fleet Team label for Observability Data Collection Fleet team v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet] Consistent display of agent counts on Lists
5 participants
@paul-tavares @elasticmachine @kibanamachine @jfsiii @kevinlog