-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Add more in-editor Advanced documentation #86821
Merged
Merged
Changes from 10 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
64c09f0
:speech_balloon: Add granularity advanced doc
dej611 b52749a
:wrench: Make advanced setting parametric
dej611 78266ac
:speech_balloon: Add auto date histogram popup
dej611 94f8b53
:speech_balloon: Add Missing values/Fitting help tooltip
dej611 fd54795
:ok_hand: Use the duration formatter from data plugin
dej611 ff02be9
:white_check_mark: Fix unit tests
dej611 03fd855
:hammer: Document data plugin API changes
dej611 6f87fdd
:wrench: Fix i18n checks
dej611 a2d5de9
Merge remote-tracking branch 'upstream/master' into doc/lens/popups
dej611 5189137
:fire: Remove unused translations
dej611 ffa15db
:ok_hand: Reworked based on feedback
dej611 0f14c6b
:baloon_speech: Add moving average popover
dej611 bef3487
:pencil2: Missed one label
dej611 a51ee89
Merge branch 'master' into doc/lens/popups
kibanamachine 23797c0
:lipstick: Fix short table problem
dej611 c417160
Merge branch 'doc/lens/popups' of github.com:dej611/kibana into doc/l…
dej611 51e4b5a
Merge remote-tracking branch 'origin/master' into HEAD
wylieconlon f691ea6
Use Kibana translations instead of moment
wylieconlon 34cbb44
Revert "Use Kibana translations instead of moment"
wylieconlon 4786a6d
Use Kibana translations instead of moment
wylieconlon 75e11ea
Remove unused code
wylieconlon 81917e1
Merge pull request #3 from wylieconlon/lens/advanced-docs-fork
dej611 5d840da
:speech_balloon: Revisit some interval labels
dej611 e955849
:ok_hand: Fix api doc changes
dej611 4ebc327
:speech_balloon: Improve moving_avg doc with example
dej611 167a76d
update class name; remove problematic styles
MichaelMarcialis a5b3d18
eui scroll on proper element; max width; rm icon
MichaelMarcialis e02de31
add help icon to button for consistency
MichaelMarcialis a4e77f9
created new HelpPopover component
MichaelMarcialis 4e6cf4a
change all to use new HelpPopover component
MichaelMarcialis c15d0f1
moved popover btns to labelAppend for consistency
MichaelMarcialis 69e88f9
Merge pull request #4 from MichaelMarcialis/doc/lens/popups-design
dej611 4b4db87
Merge remote-tracking branch 'upstream/master' into doc/lens/popups
dej611 cec6ff8
:bug: Fix stale help popup on operation change
dej611 0ef1b9d
:lipstick: Integrated tooltip suggestion
dej611 6592790
Merge branch 'master' into doc/lens/popups
kibanamachine 933b52c
Merge branch 'master' into doc/lens/popups
kibanamachine 3be0e5e
:speech_balloon: Rework some copy
dej611 49524fe
Merge branch 'master' into doc/lens/popups
kibanamachine 012297a
:ok_hand: Integrate new feedback
dej611 180b4af
:speech_balloon: Changed copy as last feedback
dej611 5feadf0
Merge branch 'master' into doc/lens/popups
kibanamachine 3ed6381
Merge remote-tracking branch 'upstream/master' into doc/lens/popups
dej611 b94bccf
Merge branch 'doc/lens/popups' of github.com:dej611/kibana into doc/l…
dej611 782530b
:bug: Fix api changes with rebuild
dej611 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
...ck/plugins/lens/public/indexpattern_datasource/operations/definitions/date_histogram.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
.lnsIndexPatternDimensionEditor__dateHistogramHelpPopover { | ||
max-height: 500px; | ||
max-width: 400px; | ||
overflow-y: scroll; | ||
} | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as resolved.
Sorry, something went wrong.