Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] "View job" link from latency charts leads to a malfunctioning page #86788

Merged
merged 2 commits into from
Dec 23, 2020

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Dec 22, 2020

closes #86774

On kibana advanced settings when the property Time filter refresh interval is set like:

{
  "pause": false,
  "value": 0
}

It triggers all requests every second. To avoid it, I hardcoded the pause option to true.

There's an issue open on kibana to improve it #70562

ml.-.settings.-.link.mov
ml-latency-link.mov

@cauemarcondes cauemarcondes requested a review from a team as a code owner December 22, 2020 16:10
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Dec 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, have you made sure all links to ML are working properly? E.g. setup link, settings page, service overview page, service transactions page, service map (not sure if there are more).

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1734 1735 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.4MB 5.4MB +1.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit cfec38e into elastic:master Dec 23, 2020
@cauemarcondes cauemarcondes deleted the apm-latency-ml-link branch December 23, 2020 12:00
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Dec 23, 2020
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Dec 23, 2020
cauemarcondes added a commit that referenced this pull request Dec 23, 2020
cauemarcondes added a commit that referenced this pull request Dec 23, 2020
@ogupte ogupte self-assigned this Jan 20, 2021
@ogupte ogupte added the apm:test-plan-done Pull request that was successfully tested during the test plan label Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:test-plan-7.11.0 apm:test-plan-done Pull request that was successfully tested during the test plan release_note:fix Team:APM All issues that need APM UI Team support v7.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] "View job" link from latency charts leads to a malfunctioning page
6 participants