Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Monitoring] Convert Kibana-related server files that read from _source to typescript (#86364) #86720

Merged
merged 1 commit into from
Dec 22, 2020

Conversation

chrisronline
Copy link
Contributor

Backports the following commits to 7.x:

…ce to typescript (elastic#86364)

* Identifying kibana source fields

* Fix types

* Fix types, take 2

* Should really fix it now

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	x-pack/plugins/monitoring/public/components/kibana/instances/instances.js
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 976.9KB 977.6KB +719.0B
triggersActionsUi 1.6MB 1.5MB -26.9KB
total -26.2KB

Distributable file count

id before after diff
default 47485 48249 +764

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 162.6KB 162.7KB +102.0B
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 31 32 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chrisronline chrisronline merged commit 6087f1e into elastic:7.x Dec 22, 2020
@chrisronline chrisronline deleted the backport/7.x/pr-86364 branch December 22, 2020 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants